You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/09 23:55:36 UTC

[GitHub] [geode] kirklund commented on a change in pull request #6007: GEODE-7864: Clean up InternalResourceManager

kirklund commented on a change in pull request #6007:
URL: https://github.com/apache/geode/pull/6007#discussion_r573337293



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/InternalResourceManager.java
##########
@@ -228,41 +224,29 @@ public void removeResourceListener(final ResourceType resourceType,
   public void deliverEventFromRemote(final ResourceEvent event) {
     assert !event.isLocal();
 
-    if (this.cache.getLogger().fineEnabled()) {
-      this.cache.getLogger()
+    if (cache.getLogger().fineEnabled()) {

Review comment:
       I would go ahead and replace all usages of the old proprietary LogWriter API (cache.getLogger() returns LogWriter) with Log4J2 Logger.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org