You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/08 12:39:16 UTC

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1273: Fix some clippy lints in parquet crate, rename `LevelEncoder` variants to conform to Rust standards

tustvold commented on a change in pull request #1273:
URL: https://github.com/apache/arrow-rs/pull/1273#discussion_r801586940



##########
File path: parquet/src/encodings/levels.rs
##########
@@ -50,11 +50,11 @@ pub fn max_buffer_size(
 }
 
 /// Encoder for definition/repetition levels.
-/// Currently only supports RLE and BIT_PACKED (dev/null) encoding, including v2.
+/// Currently only supports Rle and BitPacked (dev/null) encoding, including v2.
 pub enum LevelEncoder {

Review comment:
       The encodings module is experimental and so this isn't actually a breaking change. Clippy ignores proposing breaking changes to the API (at least for this lint because the salt was strong).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org