You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/14 19:42:53 UTC

[GitHub] [arrow] seddonm1 commented on a change in pull request #8906: ARROW-10817: [Rust][DataFusion] Update relevant tpch-queries with BETWEEN

seddonm1 commented on a change in pull request #8906:
URL: https://github.com/apache/arrow/pull/8906#discussion_r542697806



##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -400,7 +400,7 @@ fn create_logical_plan(ctx: &mut ExecutionContext, query: usize) -> Result<Logic
                             (n1.n_name = 'FRANCE' and n2.n_name = 'GERMANY')
                             or (n1.n_name = 'GERMANY' and n2.n_name = 'FRANCE')
                         )
-                        and l_shipdate > date '1995-01-01' and l_shipdate < date '1996-12-31'
+                        and l_shipdate between date '1995-01-01' and date '1996-12-31'

Review comment:
       I am working with Andy to increase the testing provided by the TPC-H queries here: https://github.com/apache/arrow/pull/8760#issuecomment-744076299
   
   The plan is to verify results against the correct results when run in test mode.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org