You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/21 05:16:39 UTC

[GitHub] [thrift] iceprosurface opened a new pull request, #2673: THRIFT-5634: thrift docs picture was broken

iceprosurface opened a new pull request, #2673:
URL: https://github.com/apache/thrift/pull/2673

   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes) 
     - https://issues.apache.org/jira/browse/THRIFT-5634
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   
   
   
   change :
   
   https://thrift.apache.org/docs/doc/images/cgrn.png -> https://thrift.apache.org/doc/images/cgrn.png
   https://thrift.apache.org/docs/doc/images/cred.png -> https://thrift.apache.org/doc/images/cred.png


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] iceprosurface commented on pull request #2673: THRIFT-5634: thrift docs picture was broken

Posted by GitBox <gi...@apache.org>.
iceprosurface commented on PR #2673:
URL: https://github.com/apache/thrift/pull/2673#issuecomment-1253280760

   > i wonder what is a better fix, to change all relative paths to absolute one or to just update somewhere once to fix the `docs` prefix?
   
   This is determined by the location of the static resource (image).
   
   For example:
   
   `https://thrift.apache.org/docs/Languages.html` was under `/docs/`, so that relative assets will load with prefix  `/docs/`
   
   `doc/images/cgrn.png`-> `/docs/doc/images/cgrn.png` ❌
   
   However if we change correct relative path -> `../doc/images/cgrn.png`, this will break github preview. 
   
   
   Move `doc/images` to `docs/images`, then add the `/docs` prefix to every static resource(image), maybe this is a better fix.
   
   Change all doc will break search result of search engine.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jimexist commented on pull request #2673: THRIFT-5634: thrift docs picture was broken

Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2673:
URL: https://github.com/apache/thrift/pull/2673#issuecomment-1253226975

   i wonder what is a better fix, to change all relative paths to absolute one or to just update somewhere once to fix the `docs` prefix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G merged pull request #2673: THRIFT-5634: thrift docs picture was broken

Posted by GitBox <gi...@apache.org>.
Jens-G merged PR #2673:
URL: https://github.com/apache/thrift/pull/2673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org