You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/08/12 01:52:24 UTC
Review Request 37377: Disallow HTTP schedulers when authentication is
required.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37377/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
Since we don't have authentication implemented yet, this disallows http schedulers when authentication is required.
Diffs
-----
src/master/http.cpp 7c650555ed15d310ad28e68239cbd56580fbae37
src/tests/http_api_tests.cpp 23214dfc770d9b18c85ddbdaf35b85e59eeb8acf
Diff: https://reviews.apache.org/r/37377/diff/
Testing
-------
Updated the tests.
Thanks,
Ben Mahler
Re: Review Request 37377: Disallow HTTP schedulers when
authentication is required.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37377/#review95051
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 11, 2015, 11:52 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37377/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 11:52 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we don't have authentication implemented yet, this disallows http schedulers when authentication is required.
>
>
> Diffs
> -----
>
> src/master/http.cpp 7c650555ed15d310ad28e68239cbd56580fbae37
> src/tests/http_api_tests.cpp 23214dfc770d9b18c85ddbdaf35b85e59eeb8acf
>
> Diff: https://reviews.apache.org/r/37377/diff/
>
>
> Testing
> -------
>
> Updated the tests.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 37377: Disallow HTTP schedulers when
authentication is required.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37377/#review95029
-----------------------------------------------------------
Ship it!
LGTM !
- Anand Mazumdar
On Aug. 11, 2015, 11:52 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37377/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 11:52 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we don't have authentication implemented yet, this disallows http schedulers when authentication is required.
>
>
> Diffs
> -----
>
> src/master/http.cpp 7c650555ed15d310ad28e68239cbd56580fbae37
> src/tests/http_api_tests.cpp 23214dfc770d9b18c85ddbdaf35b85e59eeb8acf
>
> Diff: https://reviews.apache.org/r/37377/diff/
>
>
> Testing
> -------
>
> Updated the tests.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 37377: Disallow HTTP schedulers when
authentication is required.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37377/#review95047
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37377]
All tests passed.
- Mesos ReviewBot
On Aug. 11, 2015, 11:52 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37377/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 11:52 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we don't have authentication implemented yet, this disallows http schedulers when authentication is required.
>
>
> Diffs
> -----
>
> src/master/http.cpp 7c650555ed15d310ad28e68239cbd56580fbae37
> src/tests/http_api_tests.cpp 23214dfc770d9b18c85ddbdaf35b85e59eeb8acf
>
> Diff: https://reviews.apache.org/r/37377/diff/
>
>
> Testing
> -------
>
> Updated the tests.
>
>
> Thanks,
>
> Ben Mahler
>
>