RE: cvs commit: httpd-2.0/modules/ssl ssl_engine_kernel.c

[Ryan Bloom <rb...@covalent.net>]

It looks like the problem is only encountered if you have an
ErrorDocument that is SSI parsed.  I obviously hadn't configured
everything properly when I was moving configurations around.  :-(  

Ryan

----------------------------------------------
Ryan Bloom                  rbb@covalent.net
645 Howard St.              rbb@apache.org
San Francisco, CA 

> -----Original Message-----
> From: Paul J. Reder [mailto:rederpj@remulak.net]
> Sent: Tuesday, June 11, 2002 6:59 AM
> To: dev@httpd.apache.org
> Subject: Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_kernel.c
> 
> Thank you kind sir, I have confirmed that this does the trick for me.
> The curious question is why Ryan was never able to reproduce it...
> 
> jwoolley@apache.org wrote:
> 
> > jwoolley    2002/06/10 21:54:01
> >
> >   Modified:    modules/ssl ssl_engine_kernel.c
> >   Log:
> >   fix the infinite recursion problem with HTTP-on-the-HTTPS port.
> >
> >   Reported by:  Paul J. Reder
> >   Submitted by: Ryan Bloom
> >
> >   Revision  Changes    Path
> >   1.76      +7 -0      httpd-2.0/modules/ssl/ssl_engine_kernel.c
> >
> >   Index: ssl_engine_kernel.c
> >
===================================================================
> >   RCS file: /home/cvs/httpd-2.0/modules/ssl/ssl_engine_kernel.c,v
> >   retrieving revision 1.75
> >   retrieving revision 1.76
> >   diff -u -d -u -r1.75 -r1.76
> >   --- ssl_engine_kernel.c	11 Jun 2002 03:45:54 -0000	1.75
> >   +++ ssl_engine_kernel.c	11 Jun 2002 04:54:01 -0000	1.76
> >   @@ -199,6 +199,13 @@
> >                                  thisurl, thisurl);
> >
> >            apr_table_setn(r->notes, "error-notes", errmsg);
> >   +
> >   +        /* Now that we have caught this error, forget it. we are
done
> >   +         * with using SSL on this request.
> >   +         */
> >   +        sslconn->non_ssl_request = 0;
> >   +
> >   +
> >            return HTTP_BAD_REQUEST;
> >        }
> >
> >
> >
> >
> >
> >
> >
> 
> 
> --
> Paul J. Reder
> -----------------------------------------------------------
> "The strength of the Constitution lies entirely in the determination
of
> each
> citizen to defend it.  Only if every single citizen feels duty bound
to do
> his share in this defense are the constitutional rights secure."
> -- Albert Einstein
>