You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Gary D. Gregory (Jira)" <ji...@apache.org> on 2019/12/31 16:23:00 UTC
[jira] [Comment Edited] (HTTPCLIENT-2044) Add and reuse singleton
instances for immutable factory objects.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006158#comment-17006158 ]
Gary D. Gregory edited comment on HTTPCLIENT-2044 at 12/31/19 4:22 PM:
-----------------------------------------------------------------------
Done. See also the PR SVP. This requires the clean up in https://github.com/apache/httpcomponents-client/pull/194 we discussed previously.
was (Author: garydgregory):
Done. See also the PR SVP.
> Add and reuse singleton instances for immutable factory objects.
> -----------------------------------------------------------------
>
> Key: HTTPCLIENT-2044
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2044
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: Gary D. Gregory
> Assignee: Gary D. Gregory
> Priority: Major
>
> In a lot of places we create instances of AuthSchemeFactory implementations like BasicSchemeFactory.
> All of these instances are the same and immutable.
> We can simplify the code and put a touch less pressure on the GC by creating singletons for these classes and then reusing them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org