[GitHub] [airflow] dstandish commented on pull request #15120: Do not log info when ssm secret not found

[GitBox <gi...@apache.org>]

dstandish commented on pull request #15120:
URL: https://github.com/apache/airflow/pull/15120#issuecomment-812579636


   > By logging error, it can be helpful if the user expects to use a specific backend for the secret or fails for unexpected reasons (PermissionDenied).
   
   Yes in theory it can be helpful. BUT it can also be misleading!  It's like when your airflow cluster goes down and you try and get it back up before your boss notices ;)  You _could_ tell them but is it really helpful to do so 😉?
   
   At my company when I implemented ssm secrets backend a user saw this error and coincidentally happened to be having other problems with a dag he was working on.  Not finding the cred was exactly what should have happened because the setup is supposed to use the aws instance profile not airflow connection.  So it's saying "error" and he never really believed that this was fully expected and unrelated to his issue.  🙂
   
   So, while those of us who understand what's happening under the hood can make sense of the error, users may not.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org