[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

[aljoscha <gi...@git.apache.org>]

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4320#discussion_r132443663
  
    --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala ---
    @@ -82,36 +78,54 @@ class PatternStream[T](jPatternStream: JPatternStream[T]) {
         *                               pattern sequence.
         * @tparam L Type of the resulting timeout event
         * @tparam R Type of the resulting event
    +    * @deprecated Use the version that returns timeouted events as a side-output
         * @return Data stream of either type which contains the resulting events and resulting timeout
         *         events.
         */
    +  @deprecated
       def select[L: TypeInformation, R: TypeInformation](
         patternTimeoutFunction: PatternTimeoutFunction[T, L],
         patternSelectFunction: PatternSelectFunction[T, R])
       : DataStream[Either[L, R]] = {
    +    val outputTag = OutputTag[L]("dummy-timeouted")
    --- End diff --
    
    Maybe don't use "dummy" for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---