You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "yestaro (GitHub)" <gi...@apache.org> on 2018/08/23 09:48:47 UTC

[GitHub] [royale-asjs] yestaro commented on issue #274: itemsExpand still not work, fix again

Hi Carlos

the test example as below, just use j:HorizontalLayout in j:List, it output nothing
```xml
<j:List id="list" percentWidth="100" height="100">  
    <j:beads>  
        <j:HorizontalLayout itemsExpand="true" />
    </j:beads>
    <j:dataProvider>
        <js:ArrayList id="avengersCharacters" source="[Iron Man, Hulk, Thor, Captain America]" />
    </j:dataProvider>
</j:List>
```
seems j:HGroup has fixed, but j:HorizontalLayout not.

I look at **StyledLayoutBase.itemsHorizontalAlign** setter has logic `if(hostComponent)`
but **itemsExpand** setter without `if(hostComponent)` that should be the problem
original StyledLayoutBase.as itemsExpand setter as below.

```actionscript
public function set itemsExpand(value:Boolean):void
        {
            if (_itemsExpand != value)
            {
                _itemsExpand = value;
				COMPILE::JS
                {
				if(_itemsExpand)
				{
					hostClassList.add("itemsExpand");
				} else
				{
					hostClassList.remove("itemsExpand");
				}
				}
            }
        }
```

[ Full content available at: https://github.com/apache/royale-asjs/pull/274 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org