You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "coteli (via GitHub)" <gi...@apache.org> on 2024/02/25 12:16:11 UTC
[PR] feat(translations):Turkish translation files added [superset]
coteli opened a new pull request, #27244:
URL: https://github.com/apache/superset/pull/27244
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Turkish language translation files created and added. Many UI elements have been translated.
I noticed some mistakes in the pull request I opened earlier, number #27237. Therefore, to avoid complications, I closed that request and opened a new one after making the necessary corrections.
I apologize to those affected by the faulty pull request and thank them for their understanding.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
<img width="1467" alt="English" src="https://github.com/apache/superset/assets/32729663/856af783-bef1-4438-aefc-3d65a9aead2d">
<img width="1467" alt="Turkish" src="https://github.com/apache/superset/assets/32729663/03b668ac-ddbd-45db-9b08-177403709a94">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(translations): Turkish translation files added [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #27244:
URL: https://github.com/apache/superset/pull/27244#issuecomment-1979388668
@rusackas this might need your stamp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(translations): Turkish translation files added [superset]
Posted by "coteli (via GitHub)" <gi...@apache.org>.
coteli commented on PR #27244:
URL: https://github.com/apache/superset/pull/27244#issuecomment-1969554696
> You can run the [pre-commit hooks](https://superset.apache.org/docs/contributing/hooks-and-linting/) to fix the linting issues
I run pre-commit hooks and all checks have passed. I hope it works, thanks for helping.
<img width="936" alt="Ekran Resmi 2024-02-28 20 57 43" src="https://github.com/apache/superset/assets/32729663/aaa71e32-3a10-4195-b3be-90459fb2d391">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(translations):Turkish translation files added [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27244:
URL: https://github.com/apache/superset/pull/27244#issuecomment-1964758625
@mistercrunch seems like the auto-labeler didn't find it's config here, and didn't add all the i18n labels like it did on this PR's predecessor. Not sure if you happen to know why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(translations): Turkish translation files added [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27244:
URL: https://github.com/apache/superset/pull/27244#issuecomment-1968320838
You can run the [pre-commit hooks](https://superset.apache.org/docs/contributing/hooks-and-linting/) to fix the linting issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(translations):Turkish translation files added [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #27244:
URL: https://github.com/apache/superset/pull/27244#issuecomment-1966807442
Hello @coteli thanks for the PR! CI needs a bit of love, some linting required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(translations): Turkish translation files added [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #27244:
URL: https://github.com/apache/superset/pull/27244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(translations): Turkish translation files added [superset]
Posted by "coteli (via GitHub)" <gi...@apache.org>.
coteli commented on PR #27244:
URL: https://github.com/apache/superset/pull/27244#issuecomment-1973643452
> Hello @coteli there was a problem with a unit test on master that is affecting this PR. Please, pull fresh master and push back, it should solve the issue. Thank you
Hello @geido, thank you for your advice. I synced my branch with apache:master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(translations):Turkish translation files added [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27244:
URL: https://github.com/apache/superset/pull/27244#issuecomment-1963375150
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27244?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 59.65%. Comparing base [(`1d571ec`)](https://app.codecov.io/gh/apache/superset/commit/1d571ec9e6e769d9715ee1e5c398aca079ba6207?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9213da4`)](https://app.codecov.io/gh/apache/superset/pull/27244?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #27244 +/- ##
===========================================
- Coverage 69.69% 59.65% -10.04%
===========================================
Files 1908 1908
Lines 74530 74530
Branches 8309 8309
===========================================
- Hits 51942 44463 -7479
- Misses 20535 28014 +7479
Partials 2053 2053
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/27244/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/27244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/27244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/27244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/27244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.73% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/27244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.31% <ø> (-20.82%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/27244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/27244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.51% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27244?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(translations): Turkish translation files added [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #27244:
URL: https://github.com/apache/superset/pull/27244#issuecomment-1971504430
Hello @coteli there was a problem with a unit test on master that is affecting this PR. Please, pull fresh master and push back, it should solve the issue. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(translations): Turkish translation files added [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27244:
URL: https://github.com/apache/superset/pull/27244#issuecomment-1973681998
Thanks! Running CI 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org