[jira] [Commented] (DRILL-4527) Remove unnecessary code: DrillAvgVarianceConvertlet.java

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013709#comment-17013709 ] 

ASF GitHub Bot commented on DRILL-4527:
---------------------------------------

vvysotskyi commented on pull request #441: DRILL-4527: remove DrillAvgVarianceConvertlet
URL: https://github.com/apache/drill/pull/441
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove unnecessary code:  DrillAvgVarianceConvertlet.java
> ---------------------------------------------------------
>
>                 Key: DRILL-4527
>                 URL: https://issues.apache.org/jira/browse/DRILL-4527
>             Project: Apache Drill
>          Issue Type: Bug
>          Components:  Server
>            Reporter: MinJi Kim
>            Assignee: Igor Guzenko
>            Priority: Major
>             Fix For: 1.18.0
>
>
> DrillConvertletTable is used as a way to have custom functions.  For example, for EXTRACT(), DrilLConvertletTable.get() returns DrillExtractConvertlet, which returns a custom RexNode for the extract function.  
> On the other hand, DrillAvgVarianceConvertlet is never used.  stddev/avg/variance functions are handled by DrillAggregateRule and DrillReduceAggregatesRule.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)