You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/05 09:47:57 UTC
[GitHub] [apisix] kwanhur opened a new pull request, #7193: docs(response-rewrite): change image source from jsdelivr to github
kwanhur opened a new pull request, #7193:
URL: https://github.com/apache/apisix/pull/7193
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
Change plugin response-rewrite `ngx.exit` image source. Bcz jsdelivr cann't be accessed in somewhere, so load it from github.
<!-- Please also include relevant motivation and context. -->
Fixes #7149
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7193: docs(response-rewrite): change image source from jsdelivr to github
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #7193:
URL: https://github.com/apache/apisix/pull/7193#discussion_r896319977
##########
docs/zh/latest/plugins/response-rewrite.md:
##########
@@ -125,7 +125,7 @@ X-Server-balancer_addr: 127.0.0.1:80
如果你在 `access` 阶段执行了 `ngx.exit`，该操作只是中断了请求处理阶段，响应阶段仍然会处理。如果你配置了 `response-rewrite` 插件，它会强制覆盖你的响应信息（如响应代码）。
-
+
Review Comment:
Thanks! cc @hf400159 to have a check 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7193: docs(response-rewrite): change image source from jsdelivr to github
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #7193:
URL: https://github.com/apache/apisix/pull/7193#discussion_r890691867
##########
docs/zh/latest/plugins/response-rewrite.md:
##########
@@ -125,7 +125,7 @@ X-Server-balancer_addr: 127.0.0.1:80
如果你在 `access` 阶段执行了 `ngx.exit`，该操作只是中断了请求处理阶段，响应阶段仍然会处理。如果你配置了 `response-rewrite` 插件，它会强制覆盖你的响应信息（如响应代码）。
-
+
Review Comment:
This way is more miantainable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] hf400159 commented on a diff in pull request #7193: docs(response-rewrite): change image source from jsdelivr to github
Posted by GitBox <gi...@apache.org>.
hf400159 commented on code in PR #7193:
URL: https://github.com/apache/apisix/pull/7193#discussion_r889769131
##########
docs/zh/latest/plugins/response-rewrite.md:
##########
@@ -125,7 +125,7 @@ X-Server-balancer_addr: 127.0.0.1:80
如果你在 `access` 阶段执行了 `ngx.exit`，该操作只是中断了请求处理阶段，响应阶段仍然会处理。如果你配置了 `response-rewrite` 插件，它会强制覆盖你的响应信息（如响应代码）。
-
+
Review Comment:
This picture is a table, can we turn it into a table? Like the table under properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7193: docs(response-rewrite): change image source from jsdelivr to github
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #7193:
URL: https://github.com/apache/apisix/pull/7193#discussion_r890691713
##########
docs/zh/latest/plugins/response-rewrite.md:
##########
@@ -125,7 +125,7 @@ X-Server-balancer_addr: 127.0.0.1:80
如果你在 `access` 阶段执行了 `ngx.exit`，该操作只是中断了请求处理阶段，响应阶段仍然会处理。如果你配置了 `response-rewrite` 插件，它会强制覆盖你的响应信息（如响应代码）。
-
+
Review Comment:
Good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on a diff in pull request #7193: docs(response-rewrite): change image source from jsdelivr to github
Posted by GitBox <gi...@apache.org>.
kwanhur commented on code in PR #7193:
URL: https://github.com/apache/apisix/pull/7193#discussion_r895892285
##########
docs/zh/latest/plugins/response-rewrite.md:
##########
@@ -125,7 +125,7 @@ X-Server-balancer_addr: 127.0.0.1:80
如果你在 `access` 阶段执行了 `ngx.exit`，该操作只是中断了请求处理阶段，响应阶段仍然会处理。如果你配置了 `response-rewrite` 插件，它会强制覆盖你的响应信息（如响应代码）。
-
+
Review Comment:
Done. Pls take a review @juzhiyuan @hf400159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7193: docs(response-rewrite): change image source from jsdelivr to github
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7193:
URL: https://github.com/apache/apisix/pull/7193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7193: docs(response-rewrite): change image source from jsdelivr to github
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #7193:
URL: https://github.com/apache/apisix/pull/7193#discussion_r890691867
##########
docs/zh/latest/plugins/response-rewrite.md:
##########
@@ -125,7 +125,7 @@ X-Server-balancer_addr: 127.0.0.1:80
如果你在 `access` 阶段执行了 `ngx.exit`，该操作只是中断了请求处理阶段，响应阶段仍然会处理。如果你配置了 `response-rewrite` 插件，它会强制覆盖你的响应信息（如响应代码）。
-
+
Review Comment:
This way is more maintainable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on a diff in pull request #7193: docs(response-rewrite): change image source from jsdelivr to github
Posted by GitBox <gi...@apache.org>.
kwanhur commented on code in PR #7193:
URL: https://github.com/apache/apisix/pull/7193#discussion_r893037708
##########
docs/zh/latest/plugins/response-rewrite.md:
##########
@@ -125,7 +125,7 @@ X-Server-balancer_addr: 127.0.0.1:80
如果你在 `access` 阶段执行了 `ngx.exit`，该操作只是中断了请求处理阶段，响应阶段仍然会处理。如果你配置了 `response-rewrite` 插件，它会强制覆盖你的响应信息（如响应代码）。
-
+
Review Comment:
Ok, I'll change with plaintext table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org