You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/04 10:49:43 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #18733: [fix][cli] pulsar broker {-g|-h} should exit normally
tisonkun opened a new pull request, #18733:
URL: https://github.com/apache/pulsar/pull/18733
This is somewhat of a blocker to https://github.com/apache/pulsar/issues/18721.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #18733: [fix][cli] pulsar cli should exit normally on help and generate doc
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #18733:
URL: https://github.com/apache/pulsar/pull/18733#issuecomment-1336420762
Please pay attention to `FunctionWorkerStarter`
https://github.com/apache/pulsar/blob/3e18974f0bada394b3a87915e0589d1cd0e1ec17/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionWorkerStarter.java#L55-L66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18733: [fix][cli] pulsar cli should exit normally on help and generate doc
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18733:
URL: https://github.com/apache/pulsar/pull/18733#issuecomment-1336421510
@yuruguo fixed at a521c9e4e69bee07dc8e952fafed160bc8884c8f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18733: [fix][cli] pulsar cli should exit normally on help and generate doc
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18733:
URL: https://github.com/apache/pulsar/pull/18733#issuecomment-1336450881
Merging..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18733: [fix][cli] pulsar broker {-g|-h} should exit normally
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18733:
URL: https://github.com/apache/pulsar/pull/18733#issuecomment-1336392835
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18733?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18733](https://codecov.io/gh/apache/pulsar/pull/18733?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (093bdad) into [master](https://codecov.io/gh/apache/pulsar/commit/3df506de099f27d4c3b7fbf2064db881ffda0402?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3df506d) will **decrease** coverage by `9.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/18733?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18733 +/- ##
============================================
- Coverage 46.30% 37.09% -9.21%
+ Complexity 10379 1968 -8411
============================================
Files 703 209 -494
Lines 68795 14421 -54374
Branches 7373 1573 -5800
============================================
- Hits 31853 5350 -26503
+ Misses 33358 8484 -24874
+ Partials 3584 587 -2997
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `37.09% <ø> (-9.21%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/18733?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/pulsar/client/impl/ConnectionHandler.java](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0Nvbm5lY3Rpb25IYW5kbGVyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | :arrow_down: |
| [...va/org/apache/pulsar/client/impl/ProducerBase.java](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Byb2R1Y2VyQmFzZS5qYXZh) | `32.69% <0.00%> (-1.93%)` | :arrow_down: |
| [...in/java/org/apache/pulsar/PulsarBrokerStarter.java](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhckJyb2tlclN0YXJ0ZXIuamF2YQ==) | | |
| [.../org/apache/pulsar/broker/admin/v1/Namespaces.java](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9OYW1lc3BhY2VzLmphdmE=) | | |
| [...che/pulsar/broker/intercept/BrokerInterceptor.java](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9pbnRlcmNlcHQvQnJva2VySW50ZXJjZXB0b3IuamF2YQ==) | | |
| [...he/pulsar/broker/service/AbstractSubscription.java](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0Fic3RyYWN0U3Vic2NyaXB0aW9uLmphdmE=) | | |
| [...roker/service/schema/SchemaCompatibilityCheck.java](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9TY2hlbWFDb21wYXRpYmlsaXR5Q2hlY2suamF2YQ==) | | |
| [...ulsar/utils/ConcurrentBitmapSortedLongPairSet.java](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3V0aWxzL0NvbmN1cnJlbnRCaXRtYXBTb3J0ZWRMb25nUGFpclNldC5qYXZh) | | |
| [.../service/schema/validator/SchemaDataValidator.java](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS92YWxpZGF0b3IvU2NoZW1hRGF0YVZhbGlkYXRvci5qYXZh) | | |
| [...org/apache/pulsar/broker/stats/NamespaceStats.java](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9OYW1lc3BhY2VTdGF0cy5qYXZh) | | |
| ... and [487 more](https://codecov.io/gh/apache/pulsar/pull/18733/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #18733: [fix][cli] pulsar cli should exit normally on help and generate doc
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #18733:
URL: https://github.com/apache/pulsar/pull/18733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org