You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Dan Hecht (Code Review)" <ge...@cloudera.org> on 2016/12/09 00:14:55 UTC
[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions
Dan Hecht has uploaded a new patch set (#3).
Change subject: IMPALA-4631: don't use floating point operations for time unit conversions
......................................................................
IMPALA-4631: don't use floating point operations for time unit conversions
This was leading to the PlanFragmentExecutor::Close() DCHECK because
with floating point we can have c * a + c * b > c * (a + b). Also note
this is much more likely to happen when using the MONOTONIC_COARSE since
that will result in the nested scoped timers ending up starting/stopping
at exactly the same time. Additionally, the new code is faster.
Change-Id: I7237f579b201f5bd3930f66e9c2c8d700c37ffeb
---
M be/src/gutil/walltime.h
M be/src/util/stopwatch.h
M be/src/util/time.h
3 files changed, 16 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/5434/3
--
To view, visit http://gerrit.cloudera.org:8080/5434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7237f579b201f5bd3930f66e9c2c8d700c37ffeb
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>