[GitHub] [solr] laminelam commented on a diff in pull request #826: SOLR-15857: Add Secret Manager support for ZK ACL credentials

[GitBox <gi...@apache.org>]

laminelam commented on code in PR #826:
URL: https://github.com/apache/solr/pull/826#discussion_r866120289


##########
solr/modules/aws-secret-provider/README.md:
##########
@@ -0,0 +1,80 @@
+Apache Solr - AWS Secret Provider
+===========================
+
+An implementation of `SecretCredentialsProvider` that pulls Zookeeper credentials from an AWS Secret Manager.
+
+This plugin uses the [default AWS credentials provider chain](https://docs.aws.amazon.com/sdk-for-java/v2/developer-guide/credentials.html), so ensure that your credentials are set appropriately (e.g., via env var, or in `~/.aws/credentials`, etc.).
+
+## Usage
+
+- To enable this feature copy the jar files in `modules/aws-secret-provider/lib` to `SOLR_INSTALL/server/solr-webapp/webapp/WEB-INF/lib/` and add follow the below steps before restarting Solr.

Review Comment:
   Thank you very much @gerlowskija for your reviews and time on this.
   
   Yeah this is where I was stuck for several days (weeks)…. The issue here is that classes in _contrib/module_ are not available to _Solrj_  (throwing _ClassNotFoundException_), except if I copied the jars to _solr-webapp/webapp/WEB-INF/lib_.
   
   _SolrZkClient_ (solrj module) is where ZK ACL related classes are instantiated. If the class you’re trying to instantiate is part of a _contrib/module_ you end up with _ClassNotFoundException_ error.
   
   
   Using the lib dir option doesn’t help because:
   1) you would need to add the jars paths into _solrconfig.xml_, but this is a cluster wide feature (not specific to some collection)... 
   2) more importantly, Solrj needs first to connect to ZK before it reads _solrconfig_... So the lib needs to be ready before then... it has to be available at the start up before loading anything form zookeeper.
   
   In nutshell, the lib needs to be available to _SolrZkClient_ (= solrj module)
   
   Will take a look to this new [SOLR_MODULES env-var support](https://github.com/apache/solr/blob/main/solr/solr-ref-guide/modules/configuration-guide/pages/solr-modules.adoc) feature (it wasn't there when I started this).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org