You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/05/03 21:17:20 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #29602: Change config max tis per query

uranusjr commented on code in PR #29602:
URL: https://github.com/apache/airflow/pull/29602#discussion_r1184296172


##########
airflow/configuration.py:
##########
@@ -390,8 +390,14 @@ def _validate_max_tis_per_query(self) -> None:
 
         """
         # TODO: this type of checking can be generalized like the deprecate checking
-        max_tis_per_query = self.getint("scheduler", "max_tis_per_query")
-        parallelism = self.getint("core", "parallelism")
+        try:
+            max_tis_per_query = self.getint("scheduler", "max_tis_per_query")
+            parallelism = self.getint("core", "parallelism")
+        except AirflowConfigException:
+            # in case any of the above config not found, return directly
+            # this could happens in some unit tests

Review Comment:
   Which unit tests? We can just add them to the config for them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org