You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2018/12/05 16:00:32 UTC

[native-toolchain-CR] IMPALA-7924: Add Thrift 0.11.0 to the toolchain 

Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12034


Change subject: IMPALA-7924: Add Thrift 0.11.0 to the toolchain
......................................................................

IMPALA-7924: Add Thrift 0.11.0 to the toolchain

Adds Thrift 0.11.0 to the toolchain. One patch from 0.9.3 is carried
over that preserves compatibility forward compatibility of TLS
protocols. Another path was added (THRIFT-4417), which is required for
fb303.thrift C++ code to build.

Change-Id: Idb07f43e70844b11ec79c708cab3820628a44cd2
---
M buildall.sh
A source/thrift/thrift-0.11.0-patches/0001-TLS-forward-compatibility.patch
A source/thrift/thrift-0.11.0-patches/0002-THRIFT-4417.patch
3 files changed, 82 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/34/12034/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb07f43e70844b11ec79c708cab3820628a44cd2
Gerrit-Change-Number: 12034
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>

[native-toolchain-CR] IMPALA-7924: Add Thrift 0.11.0 to the toolchain

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12034 )

Change subject: IMPALA-7924: Add Thrift 0.11.0 to the toolchain
......................................................................


Patch Set 2: Verified+1 Code-Review+2

Verified in private builds.


-- 
To view, visit http://gerrit.cloudera.org:8080/12034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb07f43e70844b11ec79c708cab3820628a44cd2
Gerrit-Change-Number: 12034
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 21:15:58 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-7924: Add Thrift 0.11.0 to the toolchain

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12034 )

Change subject: IMPALA-7924: Add Thrift 0.11.0 to the toolchain
......................................................................

IMPALA-7924: Add Thrift 0.11.0 to the toolchain

Adds Thrift 0.11.0 to the toolchain. One patch from 0.9.3 is carried
over that preserves compatibility forward compatibility of TLS
protocols. Another path was added (THRIFT-4417), which is required for
fb303.thrift C++ code to build.

Change-Id: Idb07f43e70844b11ec79c708cab3820628a44cd2
Reviewed-on: http://gerrit.cloudera.org:8080/12034
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
M buildall.sh
A source/thrift/thrift-0.11.0-patches/0001-TLS-forward-compatibility.patch
A source/thrift/thrift-0.11.0-patches/0002-THRIFT-4417.patch
3 files changed, 82 insertions(+), 0 deletions(-)

Approvals:
  Lars Volker: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb07f43e70844b11ec79c708cab3820628a44cd2
Gerrit-Change-Number: 12034
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[native-toolchain-CR] IMPALA-7924: Add Thrift 0.11.0 to the toolchain

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12034 )

Change subject: IMPALA-7924: Add Thrift 0.11.0 to the toolchain
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb07f43e70844b11ec79c708cab3820628a44cd2
Gerrit-Change-Number: 12034
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Dec 2018 18:48:31 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-7924: Add Thrift 0.11.0 to the toolchain

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12034 )

Change subject: IMPALA-7924: Add Thrift 0.11.0 to the toolchain
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb07f43e70844b11ec79c708cab3820628a44cd2
Gerrit-Change-Number: 12034
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Dec 2018 18:22:36 +0000
Gerrit-HasComments: No