You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/09 00:44:42 UTC
[GitHub] [incubator-pinot] haibow commented on issue #4774: Refactor
virtualColumn
haibow commented on issue #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#issuecomment-552045427
> > I have updated the diff to keep the virtualColumn as is since nothing new is introduced here. I will defer the renaming to future diffs where the usage of virtualColumn is expanded - hopefully then we can discuss with more context.
>
> I was going to suggest this. It is is also easier to review
I have done the change. Mind taking another look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org