You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jchen21 (GitHub)" <gi...@apache.org> on 2019/02/20 00:16:28 UTC

[GitHub] [geode] jchen21 opened pull request #3207: GEODE-6431: Change default catalog and schema to null

Authored-by: Jianxia Chen <jc...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jchen21 closed pull request #3207: GEODE-6431: Change default catalog and schema to null

Posted by "jchen21 (GitHub)" <gi...@apache.org>.
[ pull request closed by jchen21 ]

[ Full content available at: https://github.com/apache/geode/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Dakta commented on issue #3207: GEODE-6431: Change default catalog and schema to null

Posted by "Dakta (GitHub)" <gi...@apache.org>.
> Add a test (maybe to TableMetaDataManagerIntegrationTest) that defines the same table name in two different schemas. In that case if the defaults of "null" are used then both tables should be found and that should be an error

It looks like the behavior depends on the underlying database provider. Since different database systems have different treatment of "catalog", "schema", and "database", it may not even be possible to connect to a database server without specifying a valid catalog/schema combination.

For example, MySQL treats catalog/schema/database as synonymous terms, but JDBC will only connect to a server if a database is provided in the URI, or if a catalog is provided in the `jdbc-mapping`. In either case, it is not possible to create a database connection to a MySQL server that is not already limited/constrained to a single database. So a MySQL connection will never return results from more than one catalog/schema/database.

[ Full content available at: https://github.com/apache/geode/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jchen21 commented on issue #3207: GEODE-6431: Change default catalog and schema to null

Posted by "jchen21 (GitHub)" <gi...@apache.org>.
@gemzdude @BenjaminPerryRoss 

[ Full content available at: https://github.com/apache/geode/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org