You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/02 05:27:14 UTC

[GitHub] [airflow] xinbinhuang edited a comment on pull request #15142: Add support for labelling DAG edges (WIP)

xinbinhuang edited a comment on pull request #15142:
URL: https://github.com/apache/airflow/pull/15142#issuecomment-812326424


   How about `task1 >> "this is a label" | task2`? This is the exact opposite of the Beam Python SDK [example here](https://beam.apache.org/documentation/sdks/python-streaming/). 
   
   Though I am a bit hesitant to introduce another special operator for Airflow, I think it's still better to introduce a `Label` inheriting from `TaskMixin` for these 2 reasons:
   
   - Conceptually, label and task should not be treated the same. The label is metadata but the task is a task. They are different in both UI and execution.
   - In general, I don't like the *explicit* import of UI components in DAG code. I think DAG code should focus on execution/dependency logic
   
   > If we ever want to add edge information beyond just a label (e.g. add a longer description), it means we have to go back to this pattern
   
   Can you give an example of a long description that has to use `Label` for but not otherwise?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org