You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Quinn Leng <qu...@gmail.com> on 2017/07/13 00:22:34 UTC
Re: Review Request 60820: Add class definition for SlaveID,
ContainerID acceptors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/
-----------------------------------------------------------
(Updated July 13, 2017, 12:22 a.m.)
Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
Summary (updated)
-----------------
Add class definition for SlaveID, ContainerID acceptors.
Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630
Repository: mesos
Description (updated)
-------
Add class definition for SlaveID, ContainerID acceptors.
To resolve dependency issue
(correlation between these three endpoints through SlaveWriter, FullFrameworkWriter)
between reviews
https://reviews.apache.org/r/60712/ ,
https://reviews.apache.org/r/60580/ ,
https://reviews.apache.org/r/60581/
These three patches are merged and closed. This is
the class definition part of the merged code.
Diffs (updated)
-----
src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
Diff: https://reviews.apache.org/r/60820/diff/2/
Changes: https://reviews.apache.org/r/60820/diff/1-2/
Testing
-------
make check -j48
Thanks,
Quinn Leng
Re: Review Request 60820: Added class definition for SlaveID,
ContainerID acceptors.
Posted by Quinn Leng <qu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180465
-----------------------------------------------------------
src/common/http.hpp
Lines 204-205 (patched)
<https://reviews.apache.org/r/60820/#comment255642>
New line between these two lines
- Quinn Leng
On July 13, 2017, 8:23 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> -----------------------------------------------------------
>
> (Updated July 13, 2017, 8:23 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit contains the class definitions for SlaveIDAcceptor and
> ContainerIDAcceptor, which are used to filter the
> '/master/frameworks', '/master/slaves' and '/slave/containers'
> endpoints.
>
>
> Diffs
> -----
>
> src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
> src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
>
>
> Diff: https://reviews.apache.org/r/60820/diff/6/
>
>
> Testing
> -------
>
> make check -j48
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 60820: Added class definition for SlaveID,
ContainerID acceptors.
Posted by Quinn Leng <qu...@gmail.com>.
> On July 18, 2017, 5:54 p.m., Alexander Rojas wrote:
> > src/common/http.hpp
> > Lines 205 (patched)
> > <https://reviews.apache.org/r/60820/diff/7/?file=1776508#file1776508line205>
> >
> > Why are these default constructors necesary?
It used to be necessary because we were trying to get rid of 'Owned', and using the default constructor in the /slave/containers endpoint. Now it has been replaced by templated IDAcceptor.
- Quinn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180833
-----------------------------------------------------------
On July 14, 2017, 12:10 a.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 12:10 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit contains the class definitions for SlaveIDAcceptor and
> ContainerIDAcceptor, which are used to filter the
> '/master/frameworks', '/master/slaves' and '/slave/containers'
> endpoints.
>
>
> Diffs
> -----
>
> src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
> src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
>
>
> Diff: https://reviews.apache.org/r/60820/diff/7/
>
>
> Testing
> -------
>
> make check -j48
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 60820: Added class definition for SlaveID,
ContainerID acceptors.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180833
-----------------------------------------------------------
Could you reword the commit message with a little bit more of substance?
Like how and why are these acceptors used.
src/common/http.hpp
Lines 205 (patched)
<https://reviews.apache.org/r/60820/#comment256120>
Why are these default constructors necesary?
- Alexander Rojas
On July 14, 2017, 2:10 a.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 2:10 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit contains the class definitions for SlaveIDAcceptor and
> ContainerIDAcceptor, which are used to filter the
> '/master/frameworks', '/master/slaves' and '/slave/containers'
> endpoints.
>
>
> Diffs
> -----
>
> src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
> src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
>
>
> Diff: https://reviews.apache.org/r/60820/diff/7/
>
>
> Testing
> -------
>
> make check -j48
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 60820: Added class definition for the IDAcceptor.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180859
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On July 18, 2017, 6:21 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> -----------------------------------------------------------
>
> (Updated July 18, 2017, 6:21 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit contains the class definitions for IDAcceptor, which is
> used to filter IDs in the '/master/frameworks', '/master/slaves' and
> '/slave/containers' endpoints.
>
>
> Diffs
> -----
>
> src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
> src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
> src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2
>
>
> Diff: https://reviews.apache.org/r/60820/diff/9/
>
>
> Testing
> -------
>
> make check -j48
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 60820: Added class definition for the IDAcceptor.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180841
-----------------------------------------------------------
src/common/http.hpp
Lines 197-200 (original), 197-201 (patched)
<https://reviews.apache.org/r/60820/#comment256135>
How about:
"Used to filter results for API handlers. Provides the `accept()` method to test whether a supplied ID is equal to a stored target ID. If no target ID is provided when the acceptor is constructed, it will accept all inputs."
src/common/http.hpp
Line 219 (original), 208 (patched)
<https://reviews.apache.org/r/60820/#comment256137>
Need spaces:
```
if (id.isSome()) {
```
src/common/http.hpp
Lines 217 (patched)
<https://reviews.apache.org/r/60820/#comment256138>
Spaces here as well.
src/common/http.hpp
Lines 219-220 (patched)
<https://reviews.apache.org/r/60820/#comment256136>
Newline here.
- Greg Mann
On July 18, 2017, 6:21 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> -----------------------------------------------------------
>
> (Updated July 18, 2017, 6:21 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit contains the class definitions for IDAcceptor, which is
> used to filter IDs in the '/master/frameworks', '/master/slaves',
> '/master/tasks', and '/slave/containers' endpoints.
>
>
> Diffs
> -----
>
> src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
> src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
> src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2
>
>
> Diff: https://reviews.apache.org/r/60820/diff/8/
>
>
> Testing
> -------
>
> make check -j48
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 60820: Added class definition for the IDAcceptor.
Posted by Quinn Leng <qu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/
-----------------------------------------------------------
(Updated July 18, 2017, 6:21 p.m.)
Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630
Repository: mesos
Description (updated)
-------
This commit contains the class definitions for IDAcceptor, which is
used to filter IDs in the '/master/frameworks', '/master/slaves',
'/master/tasks', and '/slave/containers' endpoints.
Diffs
-----
src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2
Diff: https://reviews.apache.org/r/60820/diff/8/
Testing
-------
make check -j48
Thanks,
Quinn Leng
Re: Review Request 60820: Added class definition for the IDAcceptor.
Posted by Quinn Leng <qu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/
-----------------------------------------------------------
(Updated July 18, 2017, 6:19 p.m.)
Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
Summary (updated)
-----------------
Added class definition for the IDAcceptor.
Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630
Repository: mesos
Description (updated)
-------
This commit contains the class definitions for IDAcceptor, which is
used to filter IDs in the '/master/frameworks', '/master/slaves' and
'/slave/containers' endpoints.
Diffs (updated)
-----
src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2
Diff: https://reviews.apache.org/r/60820/diff/8/
Changes: https://reviews.apache.org/r/60820/diff/7-8/
Testing
-------
make check -j48
Thanks,
Quinn Leng
Re: Review Request 60820: Added class definition for SlaveID,
ContainerID acceptors.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180821
-----------------------------------------------------------
src/common/http.hpp
Lines 197-198 (original), 197-211 (patched)
<https://reviews.apache.org/r/60820/#comment256098>
Could you put all of these `XXXIDAcceptor` declarations and definitions in alphabetical order?
- Greg Mann
On July 14, 2017, 12:10 a.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 12:10 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit contains the class definitions for SlaveIDAcceptor and
> ContainerIDAcceptor, which are used to filter the
> '/master/frameworks', '/master/slaves' and '/slave/containers'
> endpoints.
>
>
> Diffs
> -----
>
> src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
> src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
>
>
> Diff: https://reviews.apache.org/r/60820/diff/7/
>
>
> Testing
> -------
>
> make check -j48
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 60820: Added class definition for SlaveID,
ContainerID acceptors.
Posted by Quinn Leng <qu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/
-----------------------------------------------------------
(Updated July 14, 2017, 12:10 a.m.)
Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630
Repository: mesos
Description
-------
This commit contains the class definitions for SlaveIDAcceptor and
ContainerIDAcceptor, which are used to filter the
'/master/frameworks', '/master/slaves' and '/slave/containers'
endpoints.
Diffs (updated)
-----
src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
Diff: https://reviews.apache.org/r/60820/diff/7/
Changes: https://reviews.apache.org/r/60820/diff/6-7/
Testing
-------
make check -j48
Thanks,
Quinn Leng
Re: Review Request 60820: Added class definition for SlaveID,
ContainerID acceptors.
Posted by Quinn Leng <qu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/
-----------------------------------------------------------
(Updated July 13, 2017, 8:23 p.m.)
Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
Summary (updated)
-----------------
Added class definition for SlaveID, ContainerID acceptors.
Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630
Repository: mesos
Description (updated)
-------
This commit contains the class definitions for SlaveIDAcceptor and
ContainerIDAcceptor, which are used to filter the
'/master/frameworks', '/master/slaves' and '/slave/containers'
endpoints.
Diffs
-----
src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
Diff: https://reviews.apache.org/r/60820/diff/6/
Testing
-------
make check -j48
Thanks,
Quinn Leng
Re: Review Request 60820: Add class definition for SlaveID,
ContainerID acceptors.
Posted by Quinn Leng <qu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180385
-----------------------------------------------------------
To resolve dependency issue between reviews
(correlation between these three endpoints
through SlaveWriter, FullFrameworkWriter)
https://reviews.apache.org/r/60712/ ,
https://reviews.apache.org/r/60580/ ,
https://reviews.apache.org/r/60581/
These three patches are merged and closed. This is
the class definition part of the merged code.
- Quinn Leng
On July 13, 2017, 12:22 a.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> -----------------------------------------------------------
>
> (Updated July 13, 2017, 12:22 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit contains the class definition for SlaveID, ContainerID,
> which are used in filtering for '/frameworks', '/slaves' and
> '/slave/containers' endpoint.
>
>
> Diffs
> -----
>
> src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
> src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
>
>
> Diff: https://reviews.apache.org/r/60820/diff/4/
>
>
> Testing
> -------
>
> make check -j48
>
>
> Thanks,
>
> Quinn Leng
>
>