You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "NganWave (via GitHub)" <gi...@apache.org> on 2026/07/05 13:35:07 UTC

[PR] [Fix][Connector-V2] Exclude dropped columns in postgresql connector [seatunnel]

NganWave opened a new pull request, #11358:
URL: https://github.com/apache/seatunnel/pull/11358

   When reading table schema from PostgreSQL, the dropped columns will still be included in the schema.This lead to physical columns not match actual field list in table and make errors in table reading and writing.
   
   This PR fixes it by filtering out dropped columns during schema retrieval, ensuring the connector only works with valid columns.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2] Exclude dropped columns in postgresql connector [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11358:
URL: https://github.com/apache/seatunnel/pull/11358#issuecomment-4892104747

   Thanks a lot for the contribution to Apache SeaTunnel.
   
   In addition to the regression-test blocker from my earlier source review on this PR, the current `Build` gate is also still stuck in an `ACTION_REQUIRED` state because the CI workflows are not enabled for the fork yet.
   
   Good job.
   
   Thanks a lot for your valuable contribution to Apache SeaTunnel!
   
   To pass the automated CI checks for this PR, could you please enable CI workflows in your forked repository first? You can refer to the check run link below as a reference for the required CI configuration:
   https://github.com/apache/seatunnel/runs/85227819328
   
   If you run into any trouble enabling CI or encounter related errors during the process, feel free to leave a comment here. Contributors are always ready to offer help~
   
   <img width="2412" height="1472" alt="image" src="https://github.com/user-attachments/assets/6abd2ea1-da45-4d78-a81c-0158f2d7a851" />


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2] Exclude dropped columns in postgresql connector [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11358:
URL: https://github.com/apache/seatunnel/pull/11358#issuecomment-4899185174

   Thanks for the update. I checked the current head against the latest `dev` again.
   
   - base branch: `dev`
   - head SHA: `fab6d1158ffbd38f128c47b62adac4434194ffa8`
   - compare status: `diverged`
   - ahead_by: `1`
   - behind_by: `8`
   - current failing signal: `Build`
   
   On this round, the visible failing CI signal still does not look directly tied to the current PR-owned diff from Daniel's side, and the branch is still behind upstream. The lowest-cost next step is to sync with the latest `dev` and rerun CI first. If the same lane still fails on the updated head afterwards, please drop the new failing check link here and I can help narrow it down against the rebased revision.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2] Exclude dropped columns in postgresql connector [seatunnel]

Posted by "NganWave (via GitHub)" <gi...@apache.org>.
NganWave commented on PR #11358:
URL: https://github.com/apache/seatunnel/pull/11358#issuecomment-4970400417

   Thank you for reviewing my PR and guiding me through the procedure. This PR has been approved and all CI checks have passed. Could you please help merge it? I’d prefer not to rebase again to avoid triggering an unnecessary CI run. Thanks!  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2] Exclude dropped columns in postgresql connector [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11358:
URL: https://github.com/apache/seatunnel/pull/11358#issuecomment-4968428263

   Rechecked the same unchanged head `1f5afa9d263b` after the CI / merge-gate fact changed.
   
   ## Runtime path rechecked
   ```text
   JDBC catalog schema discovery
     -> AbstractJdbcCatalog.getTable(TablePath)
         -> PostgresCatalog.getSelectColumnsSql(tablePath)
             -> SELECT pg_class / pg_namespace / pg_attribute / pg_type
             -> a.attnum > 0
             -> NOT a.attisdropped
         -> PostgresCatalog.buildColumn(resultSet)
         -> TableSchema / CatalogTable returned to JdbcSource / JdbcSink metadata flow
   
   Regression coverage
     -> JdbcPostgresIT.testCatalogExcludesDroppedColumns()
         -> create table (c1, c2, c3, c4)
         -> ALTER TABLE ... DROP COLUMN c2
         -> postgresCatalog.getTable(tablePath)
         -> assert columns == [c1, c3, c4]
     -> JdbcOpenGaussIT.testCatalogExcludesDroppedColumns()
         -> same visible-column contract through OpenGaussCatalog, which inherits PostgresCatalog
   ```
   
   ## Merge conclusion
   ### Conclusion: source blocker cleared from Daniel's side; waiting for the current gate
   
   1. Blocking items
   - None from Daniel's source review on this unchanged head.
   
   2. Current gate
   - The current remaining gate is still pending: `PENDING gate: Build` (https://github.com/apache/seatunnel/runs/87058542669)
   - Daniel only has `READ` permission on this repository, so a write-capable maintainer may still need to handle the final approval / dismissal step once the gate is clear.
   
   I do not see a reopened code-side blocker from Daniel on the current head.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2] Exclude dropped columns in postgresql connector [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11358:
URL: https://github.com/apache/seatunnel/pull/11358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org