You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2018/01/29 19:46:31 UTC
mesos git commit: Revert "Replaced the `Os.Which` test to use `cat`
rather than `ping`."
Repository: mesos
Updated Branches:
refs/heads/master f0735edd2 -> 81349a123
Revert "Replaced the `Os.Which` test to use `cat` rather than `ping`."
Turns out Windows does not have `cat` installed by default.
Considering we alraedy shell out to the `ping` command in
`src/tests/containerizer/capabilities_test_helper.cpp`,
we'll just pick up `ping` as a dependency for now.
This reverts commit 981767895f1770701efeca3b8efd5c66cd34d8fc.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/81349a12
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/81349a12
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/81349a12
Branch: refs/heads/master
Commit: 81349a12381cdcd6ba94d1531ff0da263b1c2d1c
Parents: f0735ed
Author: Michael Park <mp...@apache.org>
Authored: Mon Jan 29 11:44:33 2018 -0800
Committer: Michael Park <mp...@apache.org>
Committed: Mon Jan 29 11:44:33 2018 -0800
----------------------------------------------------------------------
3rdparty/stout/tests/os_tests.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/81349a12/3rdparty/stout/tests/os_tests.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/tests/os_tests.cpp b/3rdparty/stout/tests/os_tests.cpp
index d92c8c3..11f1720 100644
--- a/3rdparty/stout/tests/os_tests.cpp
+++ b/3rdparty/stout/tests/os_tests.cpp
@@ -1039,7 +1039,7 @@ TEST_F(OsTest, SYMLINK_Realpath)
TEST_F(OsTest, Which)
{
// TODO(jieyu): Test PATH search ordering and file execution bit.
- Option<string> which = os::which("cat");
+ Option<string> which = os::which("ping");
ASSERT_SOME(which);
which = os::which("bar");