You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajani Karuturi <ra...@gmail.com> on 2014/05/23 12:23:58 UTC
Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being returned
for an ip in deleted ip range
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/
-----------------------------------------------------------
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-6756
https://issues.apache.org/jira/browse/CLOUDSTACK-6756
Repository: cloudstack-git
Description
-------
added removed columns for user_ip_address and vlan to soft delete the entries.
Diffs
-----
api/src/com/cloud/dc/Vlan.java ac9acda
api/src/com/cloud/network/IpAddress.java f831e27
engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345
engine/schema/src/com/cloud/dc/VlanVO.java ff103b9
engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3f79a76
setup/db/db/schema-430to440.sql 7fa93e7
Diff: https://reviews.apache.org/r/21853/diff/
Testing
-------
manually tested it.
Thanks,
Rajani Karuturi
Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being
returned for an ip in deleted ip range
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/#review43945
-----------------------------------------------------------
Ship it!
commit 2ab7bcade2f37cb17e071a6154fdae1d80e4ff99
Author: Rajani Karuturi <ra...@gmail.com>
Date: Fri May 23 15:50:06 2014 +0530
Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range
- Kishan Kavala
On May 23, 2014, 3:54 p.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21853/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 3:54 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6756
> https://issues.apache.org/jira/browse/CLOUDSTACK-6756
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added removed columns for user_ip_address and vlan tables to soft delete the entries.
>
>
> Diffs
> -----
>
> api/src/com/cloud/dc/Vlan.java ac9acda
> api/src/com/cloud/network/IpAddress.java f831e27
> engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345
> engine/schema/src/com/cloud/dc/VlanVO.java ff103b9
> engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3f79a76
> setup/db/db/schema-430to440.sql 7fa93e7
>
> Diff: https://reviews.apache.org/r/21853/diff/
>
>
> Testing
> -------
>
> manually tested it.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being
returned for an ip in deleted ip range
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/#review43948
-----------------------------------------------------------
Ship it!
commit ce6a53e37b982d868ae923a294cf49df5cfed27e
Author: Rajani Karuturi <ra...@gmail.com>
Date: Fri May 23 15:50:06 2014 +0530
Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range
- Kishan Kavala
On May 27, 2014, 10:15 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21853/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 10:15 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6756
> https://issues.apache.org/jira/browse/CLOUDSTACK-6756
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added removed columns for user_ip_address and vlan tables to soft delete the entries.
>
>
> Diffs
> -----
>
> api/src/com/cloud/dc/Vlan.java ac9acda
> api/src/com/cloud/network/IpAddress.java f831e27
> engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345
> engine/schema/src/com/cloud/dc/VlanVO.java ff103b9
> engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 14e29cb
> setup/db/db/schema-430to440.sql 3b525c4
>
> Diff: https://reviews.apache.org/r/21853/diff/
>
>
> Testing
> -------
>
> manually tested it.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being
returned for an ip in deleted ip range
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/#review43947
-----------------------------------------------------------
Commit ce6a53e37b982d868ae923a294cf49df5cfed27e in cloudstack's branch refs/heads/master from Rajani Karuturi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ce6a53e ]
Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range
(cherry picked from commit a6ed48fc9c5f68b46f0d2e05adefc7263c4cd0d0)
Conflicts:
setup/db/db/schema-430to440.sql
- ASF Subversion and Git Services
On May 27, 2014, 4:45 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21853/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 4:45 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6756
> https://issues.apache.org/jira/browse/CLOUDSTACK-6756
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added removed columns for user_ip_address and vlan tables to soft delete the entries.
>
>
> Diffs
> -----
>
> api/src/com/cloud/dc/Vlan.java ac9acda
> api/src/com/cloud/network/IpAddress.java f831e27
> engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345
> engine/schema/src/com/cloud/dc/VlanVO.java ff103b9
> engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 14e29cb
> setup/db/db/schema-430to440.sql 3b525c4
>
> Diff: https://reviews.apache.org/r/21853/diff/
>
>
> Testing
> -------
>
> manually tested it.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being
returned for an ip in deleted ip range
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/#review43956
-----------------------------------------------------------
Commit df42ce903d399cf30055e55bc24b84fbc0b563a9 in cloudstack's branch refs/heads/4.4 from Rajani Karuturi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=df42ce9 ]
Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range
- ASF Subversion and Git Services
On May 27, 2014, 4:45 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21853/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 4:45 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6756
> https://issues.apache.org/jira/browse/CLOUDSTACK-6756
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added removed columns for user_ip_address and vlan tables to soft delete the entries.
>
>
> Diffs
> -----
>
> api/src/com/cloud/dc/Vlan.java ac9acda
> api/src/com/cloud/network/IpAddress.java f831e27
> engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345
> engine/schema/src/com/cloud/dc/VlanVO.java ff103b9
> engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 14e29cb
> setup/db/db/schema-430to440.sql 3b525c4
>
> Diff: https://reviews.apache.org/r/21853/diff/
>
>
> Testing
> -------
>
> manually tested it.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being
returned for an ip in deleted ip range
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/
-----------------------------------------------------------
(Updated May 27, 2014, 4:45 a.m.)
Review request for cloudstack and Kishan Kavala.
Changes
-------
uploaded a new patch for master
Bugs: CLOUDSTACK-6756
https://issues.apache.org/jira/browse/CLOUDSTACK-6756
Repository: cloudstack-git
Description
-------
added removed columns for user_ip_address and vlan tables to soft delete the entries.
Diffs (updated)
-----
api/src/com/cloud/dc/Vlan.java ac9acda
api/src/com/cloud/network/IpAddress.java f831e27
engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345
engine/schema/src/com/cloud/dc/VlanVO.java ff103b9
engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 14e29cb
setup/db/db/schema-430to440.sql 3b525c4
Diff: https://reviews.apache.org/r/21853/diff/
Testing
-------
manually tested it.
Thanks,
Rajani Karuturi
Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being
returned for an ip in deleted ip range
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/#review43946
-----------------------------------------------------------
Patch does not apply to master branch. Can you please submit a another patch for master?
- Kishan Kavala
On May 23, 2014, 3:54 p.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21853/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 3:54 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6756
> https://issues.apache.org/jira/browse/CLOUDSTACK-6756
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added removed columns for user_ip_address and vlan tables to soft delete the entries.
>
>
> Diffs
> -----
>
> api/src/com/cloud/dc/Vlan.java ac9acda
> api/src/com/cloud/network/IpAddress.java f831e27
> engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345
> engine/schema/src/com/cloud/dc/VlanVO.java ff103b9
> engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3f79a76
> setup/db/db/schema-430to440.sql 7fa93e7
>
> Diff: https://reviews.apache.org/r/21853/diff/
>
>
> Testing
> -------
>
> manually tested it.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being
returned for an ip in deleted ip range
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/#review43944
-----------------------------------------------------------
Commit 2ab7bcade2f37cb17e071a6154fdae1d80e4ff99 in cloudstack's branch refs/heads/4.4-forward from Rajani Karuturi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2ab7bca ]
Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range
- ASF Subversion and Git Services
On May 23, 2014, 10:24 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21853/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 10:24 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6756
> https://issues.apache.org/jira/browse/CLOUDSTACK-6756
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added removed columns for user_ip_address and vlan tables to soft delete the entries.
>
>
> Diffs
> -----
>
> api/src/com/cloud/dc/Vlan.java ac9acda
> api/src/com/cloud/network/IpAddress.java f831e27
> engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345
> engine/schema/src/com/cloud/dc/VlanVO.java ff103b9
> engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3f79a76
> setup/db/db/schema-430to440.sql 7fa93e7
>
> Diff: https://reviews.apache.org/r/21853/diff/
>
>
> Testing
> -------
>
> manually tested it.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being
returned for an ip in deleted ip range
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/
-----------------------------------------------------------
(Updated May 23, 2014, 10:24 a.m.)
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-6756
https://issues.apache.org/jira/browse/CLOUDSTACK-6756
Repository: cloudstack-git
Description (updated)
-------
added removed columns for user_ip_address and vlan tables to soft delete the entries.
Diffs
-----
api/src/com/cloud/dc/Vlan.java ac9acda
api/src/com/cloud/network/IpAddress.java f831e27
engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345
engine/schema/src/com/cloud/dc/VlanVO.java ff103b9
engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3f79a76
setup/db/db/schema-430to440.sql 7fa93e7
Diff: https://reviews.apache.org/r/21853/diff/
Testing
-------
manually tested it.
Thanks,
Rajani Karuturi