You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/15 20:45:22 UTC

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/
-----------------------------------------------------------

(Updated June 15, 2018, 1:45 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, Greg Mann, Jie Yu, James Peach, Joseph Wu, and Till Toenshoff.


Changes
-------

Updated and moved documentation into its own file.


Repository: mesos


Description
-------

Note that while cquery and LSP support many editors, this only
demonstrates how to setup Emacs. Documentation on Vim setup is
welcome!


Diffs (updated)
-----

  docs/cquery.md PRE-CREATION 
  docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 


Diff: https://reviews.apache.org/r/67308/diff/2/

Changes: https://reviews.apache.org/r/67308/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review204881
-----------------------------------------------------------



PASS: Mesos patch 67308 was successfully built and tested.

Reviews applied: `['67308']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67308

- Mesos Reviewbot Windows


On June 15, 2018, 8:45 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> -----------------------------------------------------------
> 
> (Updated June 15, 2018, 8:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, Greg Mann, Jie Yu, James Peach, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -----
> 
>   docs/cquery.md PRE-CREATION 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review204896
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67308]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 15, 2018, 8:45 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> -----------------------------------------------------------
> 
> (Updated June 15, 2018, 8:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, Greg Mann, Jie Yu, James Peach, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -----
> 
>   docs/cquery.md PRE-CREATION 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>