You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by Simon Nash <na...@apache.org> on 2008/08/06 12:12:50 UTC
Re: svn commit: r682663 - /tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
antelder@apache.org wrote:
> Author: antelder
> Date: Tue Aug 5 03:44:07 2008
> New Revision: 682663
>
> URL: http://svn.apache.org/viewvc?rev=682663&view=rev
> Log:
> Update for latest jms binding code
>
> Modified:
> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>
> Modified: tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
> URL: http://svn.apache.org/viewvc/tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java?rev=682663&r1=682662&r2=682663&view=diff
> ==============================================================================
> --- tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java (original)
> +++ tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java Tue Aug 5 03:44:07 2008
> @@ -55,6 +55,6 @@
> Problem problem = ((DefaultLoggingMonitorImpl)monitor).getLastLoggedProblem();
>
> assertNotNull(problem);
> - assertEquals("DoesntProcessHeaders", problem.getMessageId());
> +// assertEquals("DoesntProcessHeaders", problem.getMessageId());
> }
> }
>
>
>
It looks like this change has just bypassed the test failure.
Is anyone looking into the real cause of the failure? I don't
see a JIRA open for this, so I have opened a blocking JIRA
TUSCANY-2532 and I have marked this test with an @Ignore annotation
referencing this JIRA (committed as r683210). In future I think
it would be good practice to do this for all build break test case
failures.
Simon
Re: svn commit: r682663 - /tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
Posted by Ramkumar R <ra...@gmail.com>.
Patches are now available for TUSCANY-2532. Can someone check-in the same?
Thanks.
On Wed, Aug 6, 2008 at 8:04 PM, Ramkumar R <ra...@gmail.com> wrote:
> Hi Simon,
> Looking at the recent JMSBindingProcessor.java code, I could figure out
> that this testcase is no more valid as we now process the "headers" in
> binding.jms. This was not the case earlier..... here is how the method
> looked like earlier
>
> private void parseHeaders(XMLStreamReader reader, JMSBinding
> jmsBinding) throws XMLStreamException {
> warning("DoesntProcessHeaders", jmsBinding);
> }
>
> Now, this method is been changed to handle the hearders tag, hence we can't
> see this warning anymore.
>
> I will use this JIRA, TUSCANY-2532 to remove this testcase and add new ones
> as per the latest changes.
>
>
>
> On Wed, Aug 6, 2008 at 7:28 PM, Ramkumar R <ra...@gmail.com> wrote:
>
>> Hi Simon,
>> Just trying to see, if i can figure out what's the issue here. Will post
>> my findings soon.
>>
>>
>> On Wed, Aug 6, 2008 at 3:42 PM, Simon Nash <na...@apache.org> wrote:
>>
>>> antelder@apache.org wrote:
>>>
>>>> Author: antelder
>>>> Date: Tue Aug 5 03:44:07 2008
>>>> New Revision: 682663
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=682663&view=rev
>>>> Log:
>>>> Update for latest jms binding code
>>>>
>>>> Modified:
>>>>
>>>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>>>>
>>>> Modified:
>>>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>>>> URL:
>>>> http://svn.apache.org/viewvc/tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java?rev=682663&r1=682662&r2=682663&view=diff
>>>>
>>>> ==============================================================================
>>>> ---
>>>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>>>> (original)
>>>> +++
>>>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>>>> Tue Aug 5 03:44:07 2008
>>>> @@ -55,6 +55,6 @@
>>>> Problem problem =
>>>> ((DefaultLoggingMonitorImpl)monitor).getLastLoggedProblem();
>>>> assertNotNull(problem);
>>>> - assertEquals("DoesntProcessHeaders", problem.getMessageId());
>>>> +// assertEquals("DoesntProcessHeaders", problem.getMessageId());
>>>> }
>>>> }
>>>>
>>>>
>>>>
>>>> It looks like this change has just bypassed the test failure.
>>> Is anyone looking into the real cause of the failure? I don't
>>> see a JIRA open for this, so I have opened a blocking JIRA
>>> TUSCANY-2532 and I have marked this test with an @Ignore annotation
>>> referencing this JIRA (committed as r683210). In future I think
>>> it would be good practice to do this for all build break test case
>>> failures.
>>>
>>> Simon
>>>
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Ramkumar Ramalingam
>>
>
>
>
> --
> Thanks & Regards,
> Ramkumar Ramalingam
>
--
Thanks & Regards,
Ramkumar Ramalingam
Re: svn commit: r682663 - /tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
Posted by Ramkumar R <ra...@gmail.com>.
Hi Simon,
Looking at the recent JMSBindingProcessor.java code, I could figure out that
this testcase is no more valid as we now process the "headers" in
binding.jms. This was not the case earlier..... here is how the method
looked like earlier
private void parseHeaders(XMLStreamReader reader, JMSBinding jmsBinding)
throws XMLStreamException {
warning("DoesntProcessHeaders", jmsBinding);
}
Now, this method is been changed to handle the hearders tag, hence we can't
see this warning anymore.
I will use this JIRA, TUSCANY-2532 to remove this testcase and add new ones
as per the latest changes.
On Wed, Aug 6, 2008 at 7:28 PM, Ramkumar R <ra...@gmail.com> wrote:
> Hi Simon,
> Just trying to see, if i can figure out what's the issue here. Will post my
> findings soon.
>
>
> On Wed, Aug 6, 2008 at 3:42 PM, Simon Nash <na...@apache.org> wrote:
>
>> antelder@apache.org wrote:
>>
>>> Author: antelder
>>> Date: Tue Aug 5 03:44:07 2008
>>> New Revision: 682663
>>>
>>> URL: http://svn.apache.org/viewvc?rev=682663&view=rev
>>> Log:
>>> Update for latest jms binding code
>>>
>>> Modified:
>>>
>>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>>>
>>> Modified:
>>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>>> URL:
>>> http://svn.apache.org/viewvc/tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java?rev=682663&r1=682662&r2=682663&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>>> (original)
>>> +++
>>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>>> Tue Aug 5 03:44:07 2008
>>> @@ -55,6 +55,6 @@
>>> Problem problem =
>>> ((DefaultLoggingMonitorImpl)monitor).getLastLoggedProblem();
>>> assertNotNull(problem);
>>> - assertEquals("DoesntProcessHeaders", problem.getMessageId()); +//
>>> assertEquals("DoesntProcessHeaders", problem.getMessageId()); }
>>> }
>>>
>>>
>>>
>>> It looks like this change has just bypassed the test failure.
>> Is anyone looking into the real cause of the failure? I don't
>> see a JIRA open for this, so I have opened a blocking JIRA
>> TUSCANY-2532 and I have marked this test with an @Ignore annotation
>> referencing this JIRA (committed as r683210). In future I think
>> it would be good practice to do this for all build break test case
>> failures.
>>
>> Simon
>>
>>
>
>
> --
> Thanks & Regards,
> Ramkumar Ramalingam
>
--
Thanks & Regards,
Ramkumar Ramalingam
Re: svn commit: r682663 - /tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
Posted by Ramkumar R <ra...@gmail.com>.
Hi Simon,
Just trying to see, if i can figure out what's the issue here. Will post my
findings soon.
On Wed, Aug 6, 2008 at 3:42 PM, Simon Nash <na...@apache.org> wrote:
> antelder@apache.org wrote:
>
>> Author: antelder
>> Date: Tue Aug 5 03:44:07 2008
>> New Revision: 682663
>>
>> URL: http://svn.apache.org/viewvc?rev=682663&view=rev
>> Log:
>> Update for latest jms binding code
>>
>> Modified:
>>
>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>>
>> Modified:
>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>> URL:
>> http://svn.apache.org/viewvc/tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java?rev=682663&r1=682662&r2=682663&view=diff
>>
>> ==============================================================================
>> ---
>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>> (original)
>> +++
>> tuscany/java/sca/itest/validation/src/test/java/binding/jms/DoesntProcessHeadersTestCase.java
>> Tue Aug 5 03:44:07 2008
>> @@ -55,6 +55,6 @@
>> Problem problem =
>> ((DefaultLoggingMonitorImpl)monitor).getLastLoggedProblem();
>> assertNotNull(problem);
>> - assertEquals("DoesntProcessHeaders", problem.getMessageId()); +//
>> assertEquals("DoesntProcessHeaders", problem.getMessageId()); }
>> }
>>
>>
>>
>> It looks like this change has just bypassed the test failure.
> Is anyone looking into the real cause of the failure? I don't
> see a JIRA open for this, so I have opened a blocking JIRA
> TUSCANY-2532 and I have marked this test with an @Ignore annotation
> referencing this JIRA (committed as r683210). In future I think
> it would be good practice to do this for all build break test case
> failures.
>
> Simon
>
>
--
Thanks & Regards,
Ramkumar Ramalingam