You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/21 14:15:21 UTC

[GitHub] [pulsar] cbornet opened a new pull request, #16722: Add some missing subscription metrics doc

cbornet opened a new pull request, #16722:
URL: https://github.com/apache/pulsar/pull/16722

   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `doc-not-needed` 
   (Please explain why)
     
   - [x] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927333061


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |
+| pulsar_subscription_last_acked_timestamp | Gauge | The subscription last acked message timestamp. |
+| pulsar_subscription_last_consumed_flow_timestamp | Gauge | The subscription last received consume flow command timestamp. |
+| pulsar_subscription_last_consumed_timestamp | Gauge | The subscription last consume message timestamp. |

Review Comment:
   ```suggestion
   | pulsar_subscription_last_consumed_timestamp | Gauge | The timestamp of the last consumed message on the subscription. |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927329046


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |

Review Comment:
   ```suggestion
   | pulsar_subscription_last_expire_timestamp | Gauge | The expiration timestamp of the subscription's last message. |
   ```
   Is this what you meant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet commented on pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#issuecomment-1191541213

   cc @momo-jun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927437235


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |

Review Comment:
   That's copy/pasted from javadoc. I guess your proposal is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927324899


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |
+| pulsar_subscription_last_acked_timestamp | Gauge | The subscription last acked message timestamp. |
+| pulsar_subscription_last_consumed_flow_timestamp | Gauge | The subscription last received consume flow command timestamp. |
+| pulsar_subscription_last_consumed_timestamp | Gauge | The subscription last consume message timestamp. |
+| pulsar_subscription_last_mark_delete_advanced_timestamp | Gauge | The subscription last MarkDelete position advanced timestamp. |
+| pulsar_subscription_msg_rate_expired | Gauge | The total rate of messages expired on this subscription (msg/s). |
+| pulsar_subscription_total_msg_expired | Gauge | The total messages expired on this subscription. |

Review Comment:
   ```suggestion
   | pulsar_subscription_total_msg_expired | Gauge | The total number of messages expired on this subscription. |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927333759


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |
+| pulsar_subscription_last_acked_timestamp | Gauge | The subscription last acked message timestamp. |
+| pulsar_subscription_last_consumed_flow_timestamp | Gauge | The subscription last received consume flow command timestamp. |
+| pulsar_subscription_last_consumed_timestamp | Gauge | The subscription last consume message timestamp. |
+| pulsar_subscription_last_mark_delete_advanced_timestamp | Gauge | The subscription last MarkDelete position advanced timestamp. |

Review Comment:
   ```suggestion
   | pulsar_subscription_last_mark_delete_advanced_timestamp | Gauge | The advanced timestamp of the last MarkDelete position on the subscription. |
   ```
   Is this what you meant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#issuecomment-1192236845

   @cbornet thanks for adding docs for #15042. 
   I left a few suggestions. Pls take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #16722: [improve][doc] Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#issuecomment-1197561841

   Ping @Anonymitaet for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927329046


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |

Review Comment:
   ```suggestion
   | pulsar_subscription_last_expire_timestamp | Gauge | The expiration timestamp of the last message on the subscription. |
   ```
   Is this what you meant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927324520


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |
+| pulsar_subscription_last_acked_timestamp | Gauge | The subscription last acked message timestamp. |
+| pulsar_subscription_last_consumed_flow_timestamp | Gauge | The subscription last received consume flow command timestamp. |
+| pulsar_subscription_last_consumed_timestamp | Gauge | The subscription last consume message timestamp. |
+| pulsar_subscription_last_mark_delete_advanced_timestamp | Gauge | The subscription last MarkDelete position advanced timestamp. |
+| pulsar_subscription_msg_rate_expired | Gauge | The total rate of messages expired on this subscription (msg/s). |
+| pulsar_subscription_total_msg_expired | Gauge | The total messages expired on this subscription. |
+| pulsar_subscription_msg_drop_rate | Gauge | The rate of messages dropped on this subscription (msg/s). |

Review Comment:
   ```suggestion
   | pulsar_subscription_msg_drop_rate | Gauge | The rate of messages dropped on this subscription (message per second). |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927325088


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |
+| pulsar_subscription_last_acked_timestamp | Gauge | The subscription last acked message timestamp. |
+| pulsar_subscription_last_consumed_flow_timestamp | Gauge | The subscription last received consume flow command timestamp. |
+| pulsar_subscription_last_consumed_timestamp | Gauge | The subscription last consume message timestamp. |
+| pulsar_subscription_last_mark_delete_advanced_timestamp | Gauge | The subscription last MarkDelete position advanced timestamp. |
+| pulsar_subscription_msg_rate_expired | Gauge | The total rate of messages expired on this subscription (msg/s). |

Review Comment:
   ```suggestion
   | pulsar_subscription_msg_rate_expired | Gauge | The total rate of messages expired on this subscription (message per second). |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927329424


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |
+| pulsar_subscription_last_acked_timestamp | Gauge | The subscription last acked message timestamp. |

Review Comment:
   ```suggestion
   | pulsar_subscription_last_acked_timestamp | Gauge | The timestamp of the last acknowledged message on the subscription. |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #16722: [improve][doc] Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #16722:
URL: https://github.com/apache/pulsar/pull/16722


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927329424


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |
+| pulsar_subscription_last_acked_timestamp | Gauge | The subscription last acked message timestamp. |

Review Comment:
   ```suggestion
   | pulsar_subscription_last_acked_timestamp | Gauge | The timestamp of the subscription's last acknowledged message. |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927333759


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |
+| pulsar_subscription_last_acked_timestamp | Gauge | The subscription last acked message timestamp. |
+| pulsar_subscription_last_consumed_flow_timestamp | Gauge | The subscription last received consume flow command timestamp. |
+| pulsar_subscription_last_consumed_timestamp | Gauge | The subscription last consume message timestamp. |
+| pulsar_subscription_last_mark_delete_advanced_timestamp | Gauge | The subscription last MarkDelete position advanced timestamp. |

Review Comment:
   ```suggestion
   | pulsar_subscription_last_mark_delete_advanced_timestamp | Gauge | The advanced timestamp of the last MarkDelete position on the subscription. |
   ```
   Is this what you meant? Not sure whether the concept of the advanced timestamp has been clearly conveyed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16722: Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927332792


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last message expire execution timestamp. |
+| pulsar_subscription_last_acked_timestamp | Gauge | The subscription last acked message timestamp. |
+| pulsar_subscription_last_consumed_flow_timestamp | Gauge | The subscription last received consume flow command timestamp. |

Review Comment:
   ```suggestion
   | pulsar_subscription_last_consumed_flow_timestamp | Gauge | The timestamp of the last received consume flow command on the subscription. |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet commented on pull request #16722: [improve][doc] Add some missing subscription metrics doc

Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#issuecomment-1193099253

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org