You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/18 03:22:04 UTC
[GitHub] [kafka] chia7712 commented on pull request #9764: MINOR: Eliminate KafkaScheduler#scheduleOnce in favor of KafkaScheduler#schedule
chia7712 commented on pull request #9764:
URL: https://github.com/apache/kafka/pull/9764#issuecomment-747843386
just another thought. the ```period``` can change the behavior of ```schedule```. It seems to me we should NOT give the default value to it as it is error-prone. How about moving the ```scheduleOnce``` to parent and follow your first commit to add ```delay``` and ```unit``` to ```scheduleOnce```? WDYT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org