You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/23 00:48:17 UTC
[GitHub] [incubator-mxnet] leezu opened a new pull request #17413: cmake:
remove outdated comments
leezu opened a new pull request #17413: cmake: remove outdated comments
URL: https://github.com/apache/incubator-mxnet/pull/17413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on a change in pull request
#17413: cmake: remove outdated comments
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #17413: cmake: remove outdated comments
URL: https://github.com/apache/incubator-mxnet/pull/17413#discussion_r370319727
##########
File path: CMakeLists.txt
##########
@@ -674,13 +677,7 @@ if(USE_PLUGIN_CAFFE)
endif()
endif()
-if(NOT MSVC)
- # Only add c++11 flags and definitions after cuda compiling
- add_definitions(-DDMLC_USE_CXX11)
- add_definitions(-DMSHADOW_IN_CXX11)
- set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
-else()
+if(MSVC)
Review comment:
I'm not sure why it was done before. @jermainewang added the comment and may be able to clarify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on a change in pull request
#17413: cmake: remove outdated comments
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #17413: cmake: remove outdated comments
URL: https://github.com/apache/incubator-mxnet/pull/17413#discussion_r370319953
##########
File path: CMakeLists.txt
##########
@@ -674,13 +677,7 @@ if(USE_PLUGIN_CAFFE)
endif()
endif()
-if(NOT MSVC)
- # Only add c++11 flags and definitions after cuda compiling
- add_definitions(-DDMLC_USE_CXX11)
- add_definitions(-DMSHADOW_IN_CXX11)
- set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
-else()
+if(MSVC)
Review comment:
It's no longer needed as the build works fine without it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha merged pull request #17413: cmake: remove
outdated comments
Posted by GitBox <gi...@apache.org>.
szha merged pull request #17413: cmake: remove outdated comments
URL: https://github.com/apache/incubator-mxnet/pull/17413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request
#17413: cmake: remove outdated comments
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on a change in pull request #17413: cmake: remove outdated comments
URL: https://github.com/apache/incubator-mxnet/pull/17413#discussion_r370305799
##########
File path: CMakeLists.txt
##########
@@ -674,13 +677,7 @@ if(USE_PLUGIN_CAFFE)
endif()
endif()
-if(NOT MSVC)
- # Only add c++11 flags and definitions after cuda compiling
- add_definitions(-DDMLC_USE_CXX11)
- add_definitions(-DMSHADOW_IN_CXX11)
- set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
-else()
+if(MSVC)
Review comment:
previously it was added after cuda compiling
1. why was it done before?
2. why is it no longer needed?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services