You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Miklos Gergely via Review Board <no...@reviews.apache.org> on 2020/10/30 08:41:00 UTC

Review Request 72995: Cut long methods in Driver to smaller, more manageable pieces

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72995/
-----------------------------------------------------------

Review request for hive and David Mollitor.


Bugs: HIVE-24333
    https://issues.apache.org/jira/browse/HIVE-24333


Repository: hive-git


Description
-------

Some methods in Driver are too long to be easily understandable. They should be cut into pieces to make them easier to understand.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 59ebbc41f4 
  ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 0afa657ccb 
  ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java 8817e42ed5 
  ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java 1336b92de0 


Diff: https://reviews.apache.org/r/72995/diff/1/


Testing
-------

All tests are still running fine.


Thanks,

Miklos Gergely