You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Guillaume Nodet <gn...@gmail.com> on 2018/04/12 20:57:42 UTC
[DISCUSS] Splitting sftp into its own module
It seems to me that the SFTP support in SSHD becomes quite big.
With the work envisioned to make it asynchronous, I think it should be in
its own maven module, outside sshd-core.
While the SFTP specific API and implementation is quite easy to
externalize, there is a touch point though because the SSHD client API does
provide access to the SFTP client API. This would have to be broken
somehow, but I plan to investigate and propose a PR to discuss soon...
Guillaume
Re: [DISCUSS] Splitting sftp into its own module
Posted by Guillaume Nodet <gn...@apache.org>.
gnt, that's historical ...
https://issues.apache.org/jira/secure/ViewProfile.jspa?name=gnt
2018-04-13 14:15 GMT+02:00 Jonathan Valliere <jo...@apache.org>:
> Guillaume, what is your handle on JIRA?
>
> On Fri, Apr 13, 2018 at 7:42 AM, Guillaume Nodet <gn...@apache.org>
> wrote:
>
> > I've raised https://issues.apache.org/jira/browse/SSHD-815 and attached
> a
> > PR to it.
> > There may be room for improvement on the sftp client api to make things a
> > bit easier.
> > Right now, a user would have to do:
> >
> > SftpClient client =
> > SftpClientFactory.instance().createSftpClient(session)
> >
> > whereas before the split, it would have been:
> >
> > SftpClient client = session.createSftpClient()
> >
> > Obviously, there's no backward compatible solution but it could be made
> > even easier maybe:
> >
> > SftpClient client = SftpClient.createSftpClient(session)
> >
> > Also, the default SftpClientFatory could be loaded through the
> > ServiceLoader, that could make things easily pluggable at minimal cost.
> >
> > Guillaume
> >
> >
> > 2018-04-12 22:57 GMT+02:00 Guillaume Nodet <gn...@gmail.com>:
> >
> > > It seems to me that the SFTP support in SSHD becomes quite big.
> > > With the work envisioned to make it asynchronous, I think it should be
> in
> > > its own maven module, outside sshd-core.
> > >
> > > While the SFTP specific API and implementation is quite easy to
> > > externalize, there is a touch point though because the SSHD client API
> > does
> > > provide access to the SFTP client API. This would have to be broken
> > > somehow, but I plan to investigate and propose a PR to discuss soon...
> > >
> > > Guillaume
> > >
> >
> >
> >
> > --
> > ------------------------
> > Guillaume Nodet
> >
>
--
------------------------
Guillaume Nodet
Re: [DISCUSS] Splitting sftp into its own module
Posted by Jonathan Valliere <jo...@apache.org>.
Guillaume, what is your handle on JIRA?
On Fri, Apr 13, 2018 at 7:42 AM, Guillaume Nodet <gn...@apache.org> wrote:
> I've raised https://issues.apache.org/jira/browse/SSHD-815 and attached a
> PR to it.
> There may be room for improvement on the sftp client api to make things a
> bit easier.
> Right now, a user would have to do:
>
> SftpClient client =
> SftpClientFactory.instance().createSftpClient(session)
>
> whereas before the split, it would have been:
>
> SftpClient client = session.createSftpClient()
>
> Obviously, there's no backward compatible solution but it could be made
> even easier maybe:
>
> SftpClient client = SftpClient.createSftpClient(session)
>
> Also, the default SftpClientFatory could be loaded through the
> ServiceLoader, that could make things easily pluggable at minimal cost.
>
> Guillaume
>
>
> 2018-04-12 22:57 GMT+02:00 Guillaume Nodet <gn...@gmail.com>:
>
> > It seems to me that the SFTP support in SSHD becomes quite big.
> > With the work envisioned to make it asynchronous, I think it should be in
> > its own maven module, outside sshd-core.
> >
> > While the SFTP specific API and implementation is quite easy to
> > externalize, there is a touch point though because the SSHD client API
> does
> > provide access to the SFTP client API. This would have to be broken
> > somehow, but I plan to investigate and propose a PR to discuss soon...
> >
> > Guillaume
> >
>
>
>
> --
> ------------------------
> Guillaume Nodet
>
Re: [DISCUSS] Splitting sftp into its own module
Posted by Guillaume Nodet <gn...@apache.org>.
I've raised https://issues.apache.org/jira/browse/SSHD-815 and attached a
PR to it.
There may be room for improvement on the sftp client api to make things a
bit easier.
Right now, a user would have to do:
SftpClient client =
SftpClientFactory.instance().createSftpClient(session)
whereas before the split, it would have been:
SftpClient client = session.createSftpClient()
Obviously, there's no backward compatible solution but it could be made
even easier maybe:
SftpClient client = SftpClient.createSftpClient(session)
Also, the default SftpClientFatory could be loaded through the
ServiceLoader, that could make things easily pluggable at minimal cost.
Guillaume
2018-04-12 22:57 GMT+02:00 Guillaume Nodet <gn...@gmail.com>:
> It seems to me that the SFTP support in SSHD becomes quite big.
> With the work envisioned to make it asynchronous, I think it should be in
> its own maven module, outside sshd-core.
>
> While the SFTP specific API and implementation is quite easy to
> externalize, there is a touch point though because the SSHD client API does
> provide access to the SFTP client API. This would have to be broken
> somehow, but I plan to investigate and propose a PR to discuss soon...
>
> Guillaume
>
--
------------------------
Guillaume Nodet