You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by bi...@apache.org on 2008/08/25 03:33:43 UTC

svn commit: r688596 - in /cxf/trunk: rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/client/ rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/ systests/src/test/java/org/apache/cxf/systest/jaxws/

Author: bimargulies
Date: Sun Aug 24 18:33:43 2008
New Revision: 688596

URL: http://svn.apache.org/viewvc?rev=688596&view=rev
Log:
Improve error message that results from (e.g.) use of Holder with Simple 
front end. Remove entirely Aegis test of nonexisting feature whose only 
test case has been @Ignored for a long time. Remove misleading comment 
from dynamic client unit test.

Removed:
    cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/client/HeaderTest.java
Modified:
    cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/ReflectionServiceFactoryBean.java
    cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/SimpleMessages.properties
    cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/JaxWsDynamicClientTest.java

Modified: cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/ReflectionServiceFactoryBean.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/ReflectionServiceFactoryBean.java?rev=688596&r1=688595&r2=688596&view=diff
==============================================================================
--- cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/ReflectionServiceFactoryBean.java (original)
+++ cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/ReflectionServiceFactoryBean.java Sun Aug 24 18:33:43 2008
@@ -885,6 +885,11 @@
         el.setNillable(true);
 
         XmlSchemaType tp = (XmlSchemaType)mpi.getXmlSchema();
+        if (tp == null) {
+            throw new ServiceConstructionException(new Message("INTRACTABLE_PART", LOG,
+                                                               mpi.getName(),
+                                                               mpi.getMessageInfo().getName()));
+        }
         el.setSchemaTypeName(tp.getQName());
         mpi.setXmlSchema(el);
     }

Modified: cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/SimpleMessages.properties
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/SimpleMessages.properties?rev=688596&r1=688595&r2=688596&view=diff
==============================================================================
--- cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/SimpleMessages.properties (original)
+++ cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/SimpleMessages.properties Sun Aug 24 18:33:43 2008
@@ -27,4 +27,7 @@
 REFERENCE_TO_UNDEFINED_TYPE = Schema element {0} references undefined type {1} for service {2}.
 COULD_NOT_FIND_PART = Could not find a message part matching name {0}.  Possible values are {1}.
 UNMAPPABLE_PORT_TYPE= Service class {0} method {1} part {2} cannot be mapped to schema. Check for use of a JAX-WS-specific type \
-  without the JAX-WS service factory bean.
\ No newline at end of file
+  without the JAX-WS service factory bean.
+INTRACTABLE_PART= Message part {0} of Message {1} cannot be processed. This can be caused by the use of JAX-WS-specific types \
+ without the JAX-WS service factory bean.
+ 
\ No newline at end of file

Modified: cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/JaxWsDynamicClientTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/JaxWsDynamicClientTest.java?rev=688596&r1=688595&r2=688596&view=diff
==============================================================================
--- cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/JaxWsDynamicClientTest.java (original)
+++ cxf/trunk/systests/src/test/java/org/apache/cxf/systest/jaxws/JaxWsDynamicClientTest.java Sun Aug 24 18:33:43 2008
@@ -58,7 +58,6 @@
                    launchServer(ServerNoBodyParts.class, true));
     }
     
-    //@org.junit.Ignore // until we sort out the wsdl4j problem.
     @Test
     public void testInvocation() throws Exception {
         JaxWsDynamicClientFactory dcf =