You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/30 04:45:37 UTC

[GitHub] [beam] youngoli commented on a change in pull request #16081: [py] Supporting ignore_unknown_values for WriteToBigQuery

youngoli commented on a change in pull request #16081:
URL: https://github.com/apache/beam/pull/16081#discussion_r758927066



##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -697,7 +698,8 @@ def _insert_all_rows(
           table_ref_str,
           json_rows=rows,
           row_ids=insert_ids,
-          skip_invalid_rows=True,
+          skip_invalid_rows=skip_invalid_rows,
+          ignore_unknown_values=ignore_unknown_values,

Review comment:
       Just to make sure I'm not missing anything, this is the main change in functionality right? All the other changes are just passing parameters through function signatures until they get here, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org