You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:23:12 UTC
[GitHub] [hudi] veenaypatil opened a new pull request #3066: [HUDI-1997] Adding Note for explicitly setting HIVE_AUTO_CREATE_DATABASE
veenaypatil opened a new pull request #3066:
URL: https://github.com/apache/hudi/pull/3066
## What is the purpose of the pull request
Update the documentation to add a note for setting HIVE_AUTO_CREATE_DATABASE
## Brief change log
Updated configurations.html to add note
## Committer checklist
- [X] Has a corresponding JIRA in PR title & commit
- [X] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3066: [HUDI-1997] Adding Note for explicitly setting HIVE_AUTO_CREATE_DATABASE
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3066:
URL: https://github.com/apache/hudi/pull/3066#discussion_r650379858
##########
File path: content/docs/configurations.html
##########
@@ -524,7 +524,7 @@ <h4 id="HIVE_USE_JDBC_OPT_KEY">HIVE_USE_JDBC_OPT_KEY</h4>
<h4 id="HIVE_AUTO_CREATE_DATABASE_OPT_KEY">HIVE_AUTO_CREATE_DATABASE_OPT_KEY</h4>
<p>Property: <code class="highlighter-rouge">hoodie.datasource.hive_sync.auto_create_database</code> Default: <code class="highlighter-rouge">true</code> <br />
-<span style="color:grey"> Auto create hive database if does not exists </span></p>
+<span style="color:grey"> Auto create hive database if does not exists. <b>Note</b>: for versions 0.7 and 0.8 you will have to explicitly set this to true </span></p>
Review comment:
@veenaypatil you should update the .md file instead of html file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] veenaypatil commented on pull request #3066: [HUDI-1997] Adding Note for explicitly setting HIVE_AUTO_CREATE_DATABASE
Posted by GitBox <gi...@apache.org>.
veenaypatil commented on pull request #3066:
URL: https://github.com/apache/hudi/pull/3066#issuecomment-859676059
@n3nash @vinothchandar pls review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] veenaypatil commented on a change in pull request #3066: [HUDI-1997] Adding Note for explicitly setting HIVE_AUTO_CREATE_DATABASE
Posted by GitBox <gi...@apache.org>.
veenaypatil commented on a change in pull request #3066:
URL: https://github.com/apache/hudi/pull/3066#discussion_r650388442
##########
File path: content/docs/configurations.html
##########
@@ -524,7 +524,7 @@ <h4 id="HIVE_USE_JDBC_OPT_KEY">HIVE_USE_JDBC_OPT_KEY</h4>
<h4 id="HIVE_AUTO_CREATE_DATABASE_OPT_KEY">HIVE_AUTO_CREATE_DATABASE_OPT_KEY</h4>
<p>Property: <code class="highlighter-rouge">hoodie.datasource.hive_sync.auto_create_database</code> Default: <code class="highlighter-rouge">true</code> <br />
-<span style="color:grey"> Auto create hive database if does not exists </span></p>
+<span style="color:grey"> Auto create hive database if does not exists. <b>Note</b>: for versions 0.7 and 0.8 you will have to explicitly set this to true </span></p>
Review comment:
@leesf oh ok, updated the .md file now, pls check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf merged pull request #3066: [HUDI-1997] Adding Note for explicitly setting HIVE_AUTO_CREATE_DATABASE
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #3066:
URL: https://github.com/apache/hudi/pull/3066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org