You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Andreas Veithen (JIRA)" <ji...@apache.org> on 2011/07/30 16:34:09 UTC
[jira] [Issue Comment Edited] (AXIOM-326) MIME message parser and
serializer based on Apache mime4j
[ https://issues.apache.org/jira/browse/AXIOM-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073158#comment-13073158 ]
Andreas Veithen edited comment on AXIOM-326 at 7/30/11 2:33 PM:
----------------------------------------------------------------
I think that it is possible to replace our custom MIME parsing code with mime4j without breaking any existing public APIs, with one (potential) exception, namely Attachments#getIncomingAttachmentsAsSingleStream(). Probably once we hand over the input stream to mime4j it will probably (to be confirmed) no longer be possible to give access to that stream in a well defined state. The reason is that we have no control over how much buffering mime4j does.
However:
* I didn't find a single piece of code that is using getIncomingAttachmentsAsSingleStream().
* The method was introduced by AXIOM-329, but that use case should be covered by a proper solution for AXIOM-377 (which in turn depends on the present issue).
* The method is not covered by any test case, so that we are even not sure that it still works as designed.
Therefore it is reasonable to sacrifice getIncomingAttachmentsAsSingleStream (if necessary).
was (Author: veithen):
I think that it is possible to replace our custom MIME parsing code with mime4j without breaking any existing public APIs, with one (potential) exception, namely Attachments#getIncomingAttachmentsAsSingleStream(). Probably once we hand over the input stream to mime4j it will probably (to be confirmed) no longer be possible to give access to that stream in a well defined state. The reason is that we have no control over how much buffering mime4j does.
However:
* I didn't find a single piece of code that is using getIncomingAttachmentsAsSingleStream().
* The method was introduced by AXIOM-329, but that use case should be covered by a proper solution for AXIOM-377 (which in turn depends on the present issue).
Therefore it is reasonable to sacrifice getIncomingAttachmentsAsSingleStream (if necessary).
> MIME message parser and serializer based on Apache mime4j
> ---------------------------------------------------------
>
> Key: AXIOM-326
> URL: https://issues.apache.org/jira/browse/AXIOM-326
> Project: Axiom
> Issue Type: Improvement
> Reporter: Oleg Kalnichevski
>
> MIME message parser and serializer based on Apache mime4j
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org