You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by aandis <gi...@git.apache.org> on 2018/06/14 16:37:10 UTC
[GitHub] storm pull request #2719: STORM-3105 Update hive.version to stable hive rele...
GitHub user aandis opened a pull request:
https://github.com/apache/storm/pull/2719
STORM-3105 Update hive.version to stable hive release.
[STORM-3105](https://issues.apache.org/jira/browse/STORM-3105)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aandis/storm STORM-3105
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2719.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2719
----
commit 16d3910101ae4be0db66cb6972c614b98572d098
Author: Abhishek <ab...@...>
Date: 2018-06-14T16:35:27Z
Update hive.version to last stable hive release.
----
---
[GitHub] storm issue #2719: STORM-3105 Update hive.version to stable hive release.
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2719
This actually require full tests on storm-hive as well as storm-autocreds (delegation token). Could you share how do you test the patch manually?
---
[GitHub] storm issue #2719: STORM-3105 Update hive.version to stable hive release.
Posted by aandis <gi...@git.apache.org>.
Github user aandis commented on the issue:
https://github.com/apache/storm/pull/2719
In our case, we have copied the hive [dependencies](https://github.com/apache/storm/blob/4137328b75c06771f84414c3c2113e2d1c757c08/external/storm-hive/pom.xml#L54) into our pom with the right version and can confirm that it works. I see that [storm-hive](https://github.com/apache/storm/tree/master/external/storm-hive/src/test/java/org/apache/storm/hive) already has some tests.
The point here is that `hive.version` should match the hive version being used by the user. Setting it here is just a default and the default may not work if there's a version mismatch with the actual hive version. To address that I have opened [STORM-3106](https://issues.apache.org/jira/browse/STORM-3106)
---
[GitHub] storm issue #2719: STORM-3105 Update hive.version to stable hive release.
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2719
The current build is failing because of an Enforcer rule.
```
...
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ storm-hive ---
[WARNING] Rule 1: org.apache.maven.plugins.enforcer.BannedDependencies failed with message:
Found Banned Dependency: jdk.tools:jdk.tools:jar:1.8
Use 'mvn dependency:tree' to locate the source of the banned dependencies.
...
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) on project storm-hive: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]
...
```
---
[GitHub] storm issue #2719: STORM-3105 Update hive.version to stable hive release.
Posted by aandis <gi...@git.apache.org>.
Github user aandis commented on the issue:
https://github.com/apache/storm/pull/2719
cc: @roshannaik
---