You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dpolivy <gi...@git.apache.org> on 2015/05/08 02:40:07 UTC
[GitHub] cordova-plugin-splashscreen pull request: CB-3562: Disable screen ...
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/47
CB-3562: Disable screen rotation for iPhone when splash screen is shown (updated)
This is an updated port of emarashliev's fix for CB-3562, as this bug still exists. The original PR #14 seems to be dead, however. I ported these changes over to the latest branch of the plugin, and made some minor adjustments to avoid deprecated functions.
@shazron @agrieve Given the discussion in the previous PR, hopefully this can be reviewed and incorporated quickly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpolivy/cordova-plugin-splashscreen CB3562
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit 545b0a81139dd48accc4c25ccc8c8b2052635928
Author: Emil Marashliev <em...@me.com>
Date: 2014-02-19T14:05:34Z
CB-3562 Disable screen rotation for iPhone when splash screen is shown.
commit b6e3023f31063f4d6204355e6b13c348180cf603
Author: Dan Polivy <da...@cellartracker.com>
Date: 2015-05-08T00:35:10Z
CB-3562: Disable screen rotation for iPhone when splash screen is shown.
This is a port of emarashliev's original fix for CB-3562, cleaned up
to avoid deprecated functions.
Merge branch 'master' of https://github.com/emarashliev/cordova-plugin-splashscreen into CB3562
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3562: Disable screen ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3562: Disable screen ...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/47#issuecomment-100306319
Thanks for the PR Dan -- I'm away, will take a look Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org