You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yikf (via GitHub)" <gi...@apache.org> on 2023/04/03 08:56:05 UTC
[GitHub] [spark] Yikf commented on a diff in pull request #40437: [SPARK-41259][SQL] SparkSQLDriver Output schema and result string should be consistent
Yikf commented on code in PR #40437:
URL: https://github.com/apache/spark/pull/40437#discussion_r1155673813
##########
sql/core/src/test/resources/sql-tests/results/show-tables.sql.out:
##########
@@ -60,58 +60,58 @@ SHOW TABLES
-- !query schema
struct<namespace:string,tableName:string,isTemporary:boolean>
-- !query output
-show_t1
-show_t2
-show_t3
+ show_t3 true
Review Comment:
Yes, It use `hiveResultString`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org