You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Krisztian Szucs (Jira)" <ji...@apache.org> on 2021/05/17 11:54:00 UTC
[jira] [Commented] (ARROW-12619) [Python] pyarrow sdist should not
require git
[ https://issues.apache.org/jira/browse/ARROW-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346107#comment-17346107 ]
Krisztian Szucs commented on ARROW-12619:
-----------------------------------------
There is a fallback_version configuration option for setuptools_scm which we don't use: https://github.com/pypa/setuptools_scm#configuration-parameters
Although this setting seems to have issues according to https://github.com/pypa/setuptools_scm/issues/549
We already have a workaround in setup.py for the functionality of the fallback_version option, but it is disabled for the case of sdist: https://github.com/apache/arrow/blob/master/python/setup.py#L529
> [Python] pyarrow sdist should not require git
> ---------------------------------------------
>
> Key: ARROW-12619
> URL: https://issues.apache.org/jira/browse/ARROW-12619
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Kouhei Sutou
> Priority: Major
> Fix For: 4.0.1
>
>
> {noformat}
> FROM ubuntu:20.04
> RUN apt update && apt install -y python3-pip
> RUN pip3 install --no-binary pyarrow pyarrow==4.0.0
> {noformat}
> {noformat}
> $ docker build .
> ...
> Step 3/3 : RUN pip3 install --no-binary pyarrow pyarrow==4.0.0
> ---> Running in 28d363e1c397
> Collecting pyarrow==4.0.0
> Downloading pyarrow-4.0.0.tar.gz (710 kB)
> Installing build dependencies: started
> Installing build dependencies: still running...
> Installing build dependencies: finished with status 'done'
> Getting requirements to build wheel: started
> Getting requirements to build wheel: finished with status 'done'
> Preparing wheel metadata: started
> Preparing wheel metadata: finished with status 'error'
> ERROR: Command errored out with exit status 1:
> command: /usr/bin/python3 /tmp/tmp5rqecai7 prepare_metadata_for_build_wheel /tmp/tmpc49gha3r
> cwd: /tmp/pip-install-or1g7own/pyarrow
> Complete output (42 lines):
> Traceback (most recent call last):
> File "/tmp/tmp5rqecai7", line 280, in <module>
> main()
> File "/tmp/tmp5rqecai7", line 263, in main
> json_out['return_val'] = hook(**hook_input['kwargs'])
> File "/tmp/tmp5rqecai7", line 133, in prepare_metadata_for_build_wheel
> return hook(metadata_directory, config_settings)
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 166, in prepare_metadata_for_build_wheel
> self.run_setup()
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 258, in run_setup
> super(_BuildMetaLegacyBackend,
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 150, in run_setup
> exec(compile(code, __file__, 'exec'), locals())
> File "setup.py", line 585, in <module>
> setup(
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools/__init__.py", line 153, in setup
> return distutils.core.setup(**attrs)
> File "/usr/lib/python3.8/distutils/core.py", line 108, in setup
> _setup_distribution = dist = klass(attrs)
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools/dist.py", line 434, in __init__
> _Distribution.__init__(self, {
> File "/usr/lib/python3.8/distutils/dist.py", line 292, in __init__
> self.finalize_options()
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools/dist.py", line 743, in finalize_options
> ep(self)
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools/dist.py", line 750, in _finalize_setup_keywords
> ep.load()(self, ep.name, value)
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools_scm/integration.py", line 24, in version_keyword
> dist.metadata.version = _get_version(config)
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools_scm/__init__.py", line 173, in _get_version
> parsed_version = _do_parse(config)
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools_scm/__init__.py", line 119, in _do_parse
> parse_result = _call_entrypoint_fn(config.absolute_root, config, config.parse)
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools_scm/__init__.py", line 54, in _call_entrypoint_fn
> return fn(root)
> File "setup.py", line 546, in parse_git
> return parse(root, **kwargs)
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools_scm/git.py", line 115, in parse
> require_command("git")
> File "/tmp/pip-build-env-d53awzo4/overlay/lib/python3.8/site-packages/setuptools_scm/utils.py", line 142, in require_command
> raise OSError("%r was not found" % name)
> OSError: 'git' was not found
> ----------------------------------------
> ERROR: Command errored out with exit status 1: /usr/bin/python3 /tmp/tmp5rqecai7 prepare_metadata_for_build_wheel /tmp/tmpc49gha3r Check the logs for full command output.
> The command '/bin/sh -c pip3 install --no-binary pyarrow pyarrow==4.0.0' returned a non-zero code: 1
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)