[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17590: [Refactor](Metadata tvf) Reconstruct Metadata table-value function into a more general framework.

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #17590:
URL: https://github.com/apache/doris/pull/17590#discussion_r1130318396


##########
be/src/vec/exec/scan/vmeta_scanner.h:
##########
@@ -35,7 +35,8 @@ class VMetaScanner : public VScanner {
 protected:
     Status _get_block_impl(RuntimeState* state, Block* block, bool* eos) override;
     Status _fill_block_with_remote_data(const std::vector<MutableColumnPtr>& columns);
-    Status _fetch_iceberg_metadata_batch();
+    Status _fetch_metadata(const TMetaScanRange& meta_scan_range);
+    Status _fetch_iceberg_metadata(const TMetaScanRange& meta_scan_range);
 
 private:
     VMetaScanNode* _parent;

Review Comment:
   warning: private field '_parent' is not used [clang-diagnostic-unused-private-field]
   ```cpp
       VMetaScanNode* _parent;
                      ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org