[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5877: HDFS-17117. BlockManager#processMisReplicatesAsync can periodically print reconstructionQueuesInitProgress

["haiyang1987 (via GitHub)" <gi...@apache.org>]

haiyang1987 commented on code in PR #5877:
URL: https://github.com/apache/hadoop/pull/5877#discussion_r1272112235


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -3891,6 +3891,8 @@ private void processMisReplicatesAsync() throws InterruptedException {
         // initialisation, then progress might be different.
         reconstructionQueuesInitProgress = Math.min((double) totalProcessed
             / totalBlocks, 1.0);
+        LOG.info("Reconstruction queues initialisation progress: {}, total number of blocks " +

Review Comment:
   HI @Hexiaoqiao Sir , thanks help me review it . 
   Your suggestion is right, I checked this, the print log can be moved out of the lock, I will update the PR later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org