You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2020/03/14 18:49:56 UTC

[kudu-CR] [ranger] validate the JAR file path for the subprocess 

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15435


Change subject: [ranger] validate the JAR file path for the subprocess
......................................................................

[ranger] validate the JAR file path for the subprocess

Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
---
M src/kudu/ranger/ranger_client.cc
1 file changed, 11 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/15435/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15435

to look at the new patch set (#5).

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................

[ranger] validate the JAR file path of the subprocess

This patch updates the previous flag validator for --ranger_java_path
to be group validation for all Ranger-related flags including the JAR
file path of the subprocess flag --ranger_jar_path.

Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
---
M src/kudu/ranger/ranger_client.cc
1 file changed, 22 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/15435/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [ranger] validate the JAR file path for the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path for the subprocess
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15435/1/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:

http://gerrit.cloudera.org:8080/#/c/15435/1/src/kudu/ranger/ranger_client.cc@55
PS1, Line 55: kudu-subprocess.jar
> nit: kudu-subprocess.jar
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 14 Mar 2020 23:32:41 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has removed a vote on this change.

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 7
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [ranger] validate the JAR file path for the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15435

to look at the new patch set (#2).

Change subject: [ranger] validate the JAR file path for the subprocess
......................................................................

[ranger] validate the JAR file path for the subprocess

Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
---
M src/kudu/ranger/ranger_client.cc
1 file changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/15435/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15435/6/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:

http://gerrit.cloudera.org:8080/#/c/15435/6/src/kudu/ranger/ranger_client.cc@139
PS6, Line 139: } // anonymous namespace
             : 
             : static bool ValidateRangerConfiguration() {
nit: static functions and functions that are in an anonymous namespace serve the same purpose: they're unusable outside this translation unit. Could you standardize on one?



-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Mar 2020 02:41:15 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15435/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15435/4//COMMIT_MSG@7
PS4, Line 7: the JAR file path of the subprocess
> nit: this now extends to all Ranger-related files.
Done


http://gerrit.cloudera.org:8080/#/c/15435/4/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:

http://gerrit.cloudera.org:8080/#/c/15435/4/src/kudu/ranger/ranger_client.cc@55
PS4, Line 55: 
> This change should also be documented and rationalized in the commit messag
Removed the change.



-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Mar 2020 05:33:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15435/5/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:

http://gerrit.cloudera.org:8080/#/c/15435/5/src/kudu/ranger/ranger_client.cc@145
PS5, Line 145: FLAGS_ranger_jar_path
Why not call GetJavaClasspath() here? Otherwise this validation might yield a false positive.



-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Mar 2020 05:54:47 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15435

to look at the new patch set (#7).

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................

[ranger] validate the JAR file path of the subprocess

This patch updates the previous flag validator for --ranger_java_path
to be group validation for all Ranger-related flags including the JAR
file path of the subprocess flag --ranger_jar_path.

Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
---
M src/kudu/ranger/ranger_client.cc
1 file changed, 32 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/15435/7
-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 7
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 7
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Mar 2020 05:48:07 +0000
Gerrit-HasComments: No

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15435

to look at the new patch set (#6).

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................

[ranger] validate the JAR file path of the subprocess

This patch updates the previous flag validator for --ranger_java_path
to be group validation for all Ranger-related flags including the JAR
file path of the subprocess flag --ranger_jar_path.

Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
---
M src/kudu/ranger/ranger_client.cc
1 file changed, 34 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/15435/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has removed a vote on this change.

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 7
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................


Patch Set 7: Verified+1

Unrelated flaky tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 7
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Mar 2020 18:50:47 +0000
Gerrit-HasComments: No

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15435/5/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:

http://gerrit.cloudera.org:8080/#/c/15435/5/src/kudu/ranger/ranger_client.cc@145
PS5, Line 145: ied path is not absol
> Why not call GetJavaClasspath() here? Otherwise this validation might yield
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Mar 2020 01:09:17 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] validate the JAR file path for the subprocess

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path for the subprocess
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15435/1/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:

http://gerrit.cloudera.org:8080/#/c/15435/1/src/kudu/ranger/ranger_client.cc@55
PS1, Line 55: kudu_subprocess.jar
nit: kudu-subprocess.jar



-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 14 Mar 2020 20:49:08 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] validate the JAR file path for the subprocess

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path for the subprocess
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15435/4/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:

http://gerrit.cloudera.org:8080/#/c/15435/4/src/kudu/ranger/ranger_client.cc@55
PS4, Line 55: DEFINE_string(ranger_jar_path, "kudu-subprocess.jar",
This change should also be documented and rationalized in the commit message.



-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 06:25:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] validate the JAR file path for the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15435

to look at the new patch set (#4).

Change subject: [ranger] validate the JAR file path for the subprocess
......................................................................

[ranger] validate the JAR file path for the subprocess

Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
---
M src/kudu/ranger/ranger_client.cc
1 file changed, 19 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/15435/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [ranger] validate the JAR file path for the subprocess

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path for the subprocess
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 14 Mar 2020 19:42:35 +0000
Gerrit-HasComments: No

[kudu-CR] [ranger] validate the JAR file path for the subprocess

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path for the subprocess
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15435/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15435/4//COMMIT_MSG@7
PS4, Line 7: the JAR file path for the subprocess
nit: this now extends to all Ranger-related files.



-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 15 Mar 2020 06:26:40 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................

[ranger] validate the JAR file path of the subprocess

This patch updates the previous flag validator for --ranger_java_path
to be group validation for all Ranger-related flags including the JAR
file path of the subprocess flag --ranger_jar_path.

Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Reviewed-on: http://gerrit.cloudera.org:8080/15435
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Hao Hao <ha...@cloudera.com>
---
M src/kudu/ranger/ranger_client.cc
1 file changed, 32 insertions(+), 22 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Hao Hao: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path of the subprocess
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15435/6/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:

http://gerrit.cloudera.org:8080/#/c/15435/6/src/kudu/ranger/ranger_client.cc@139
PS6, Line 139: static bool ValidateRangerConfiguration() {
             :   if (!FLAGS_ranger_config_path.empty()) {
             :     // First, check the specified path.
> nit: static functions and functions that are in an anonymous namespace serv
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 7
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Mar 2020 05:31:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] validate the JAR file path for the subprocess

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )

Change subject: [ranger] validate the JAR file path for the subprocess
......................................................................


Patch Set 1: -Code-Review

Looking at some other build failures, we should probably only do this check if it's non-empty.


-- 
To view, visit http://gerrit.cloudera.org:8080/15435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d
Gerrit-Change-Number: 15435
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 14 Mar 2020 20:07:25 +0000
Gerrit-HasComments: No