You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/19 15:05:18 UTC
[GitHub] [calcite] michaelmior commented on a change in pull request #2021: [CALCITE-3929] When deserialize UDAF aggregate call from json string,…
michaelmior commented on a change in pull request #2021:
URL: https://github.com/apache/calcite/pull/2021#discussion_r442893261
##########
File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
##########
@@ -271,7 +271,9 @@ public RelDataType toType(RelDataTypeFactory typeFactory, Object o) {
public Object toJson(AggregateCall node) {
final Map<String, Object> map = jsonBuilder.map();
- map.put("agg", toJson(node.getAggregation()));
+ Map<String, Object> aggMap = new HashMap(toJson(node.getAggregation()));
+ aggMap.put("class", node.getAggregation().getClass().getName());
Review comment:
Where is this `class` attribute used? It doesn't seem to be in [`RelJsonWriter#toAggCall`](https://github.com/apache/calcite/blob/e7d8d86dd3ab971921f5122de6c95868dec8739c/core/src/main/java/org/apache/calcite/rel/externalize/RelJsonReader.java#L278).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org