You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/10 02:48:31 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #8398: `AnalyzerModuleConfig` code improvement.

wu-sheng commented on a change in pull request #8398:
URL: https://github.com/apache/skywalking/pull/8398#discussion_r780870775



##########
File path: oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/AnalyzerModuleConfig.java
##########
@@ -50,7 +51,7 @@
      * Read component-libraries.yml for more details.
      */
     @Getter
-    private String noUpstreamRealAddressAgents = Const.EMPTY_STRING;
+    private final String noUpstreamRealAddressAgents = Const.EMPTY_STRING;

Review comment:
       This value is set by config and system env, so, can't be final.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org