You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "krishna-dave206 (via GitHub)" <gi...@apache.org> on 2025/05/18 12:01:45 UTC
[PR] Update navbar.html [mahout]
krishna-dave206 opened a new pull request, #542:
URL: https://github.com/apache/mahout/pull/542
### Purpose of PR
Describe what this PR does.
### Linked Issues
Add links to related issues.
- Closes #123
- Related to #123
### Changes Made
- [ ] Bug fix
- [ ] New feature
- [ ] Documentation update
### Important ToDos
Please mark each with an "x"
A GitHub issue exists (if not, please create one) [https://github.com/apache/mahout/issues]
- [ ] Title of PR is "Issue #XXXX: Brief Description of Changes" where XXXX is the GitHub issue number.
- [ ] Created unit tests where appropriate
- [ ] Added correct licenses on newly added files
- [ ] Assigned GitHub issue to self
- [ ] Added documentation in ScalaDocs/JavaDocs and to the website
- [ ] Successfully built and ran all unit tests, verified that all tests pass locally
If all of these items are not yet complete, but you still feel it is appropriate to open a PR, please open it as a **Draft PR** instead.
Once all requirements are met, you can mark it as ready for review.
### Breaking Changes
Does this PR introduce a breaking change?
- [ ] Yes
- [ ] No
### Testing & Verification
Describe how you tested the changes.
- [ ] Unit tests added
- [ ] Manually tested
### Checklist
- [ ] The title follows the format "MAHOUT-XXXX Brief Description"
- [ ] GitHub issue is created
- [ ] Code follows ASF guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update navbar.html [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo merged PR #542:
URL: https://github.com/apache/mahout/pull/542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update navbar.html [mahout]
Posted by "krishna-dave206 (via GitHub)" <gi...@apache.org>.
krishna-dave206 commented on PR #542:
URL: https://github.com/apache/mahout/pull/542#issuecomment-2895524334
Ok @rawkintrevo I'll do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update navbar.html [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on code in PR #542:
URL: https://github.com/apache/mahout/pull/542#discussion_r2098619792
##########
website/_includes/navbar.html:
##########
@@ -106,17 +106,16 @@
<!-- News and Events -->
<li class="nav-item dropdown">
<a class="nav-link dropdown-toggle"
- href="" id="navbarDropdownMenuLink-news-events"
- data-toggle="dropdown"
+ href="/news-and-events/news.html" id="navbarDropdownMenuLink-news-events"
aria-haspopup="true"
- aria-expanded="false">News and Events</a>
+ aria-expanded="false">Latest Project News</a>
<div class="dropdown-menu" aria-labelledby="navbarDropdownMenuLink">
<a class="dropdown-item"
href="/news-and-events/news.html">Latest Project News</a>
- <a class="dropdown-item"
+<!-- <a class="dropdown-item"
Review Comment:
just delete this (don't comment it out)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update navbar.html [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on PR #542:
URL: https://github.com/apache/mahout/pull/542#issuecomment-2904518655
thanks @krishna-dave206 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update navbar.html [mahout]
Posted by "krishna-dave206 (via GitHub)" <gi...@apache.org>.
krishna-dave206 commented on PR #542:
URL: https://github.com/apache/mahout/pull/542#issuecomment-2903172045
Removed the commented part @rawkintrevo Review at your convenience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org