You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2023/04/19 12:17:00 UTC
[jira] [Resolved] (CALCITE-5650) Obtain typesystem from dialect in RelToSqlConverterTest
[ https://issues.apache.org/jira/browse/CALCITE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stamatis Zampetakis resolved CALCITE-5650.
------------------------------------------
Fix Version/s: 1.35.0
Resolution: Fixed
Fixed in https://github.com/apache/calcite/commit/e7375ae745ec18ce9df68b4945bb521ae49a053c. Thanks for the PR [~mbudiu] and for the review [~julianhyde]!
> Obtain typesystem from dialect in RelToSqlConverterTest
> -------------------------------------------------------
>
> Key: CALCITE-5650
> URL: https://issues.apache.org/jira/browse/CALCITE-5650
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.34.0
> Reporter: Mihai Budiu
> Assignee: Mihai Budiu
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.35.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The problem is in the file SqlToRelConverterTest.java, in the static class Sql, in the following method:
> Sql dialect(SqlDialect dialect) {
> return new Sql(schemaSpec, sql, dialect, parserConfig, librarySet, config,
> relFn, transforms, typeSystem);
> }
> The problem is that the dialect may have a different type system, which is ignored in this function. I think the function should read:
> Sql dialect(SqlDialect dialect) {
> return new Sql(schemaSpec, sql, dialect, parserConfig, librarySet, config,
> relFn, transforms, dialect.getTypeSystem());
> }
> Several tests in this file do change the dialect type system.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)