You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/10/03 19:41:46 UTC
[kudu-CR](branch-1.0.x) KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4607
Change subject: KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column
......................................................................
KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column
Scan optimization could also fail in certain cases, but the fix is the
same.
Change-Id: Icba2defeffff74e86b0e266e668974bce0ad9b0e
Reviewed-on: http://gerrit.cloudera.org:8080/4541
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
(cherry picked from commit ce17a9c4eb34dcfe63c8d4321d38d18a0cb8c5c2)
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M src/kudu/common/column_predicate.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/scan_spec-test.cc
7 files changed, 99 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/4607/1
--
To view, visit http://gerrit.cloudera.org:8080/4607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icba2defeffff74e86b0e266e668974bce0ad9b0e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.0.x
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
[kudu-CR](branch-1.0.x) KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icba2defeffff74e86b0e266e668974bce0ad9b0e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.0.x
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](branch-1.0.x) KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column
......................................................................
KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column
Scan optimization could also fail in certain cases, but the fix is the
same.
Change-Id: Icba2defeffff74e86b0e266e668974bce0ad9b0e
Reviewed-on: http://gerrit.cloudera.org:8080/4541
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
(cherry picked from commit ce17a9c4eb34dcfe63c8d4321d38d18a0cb8c5c2)
Reviewed-on: http://gerrit.cloudera.org:8080/4607
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M src/kudu/common/column_predicate.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/scan_spec-test.cc
7 files changed, 99 insertions(+), 61 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icba2defeffff74e86b0e266e668974bce0ad9b0e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.0.x
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>