You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/10/25 18:50:54 UTC

[GitHub] spark pull request #22837: [MINOR][TEST] Regenerate golden file `datetime.sq...

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22837#discussion_r228293689
  
    --- Diff: sql/core/src/test/resources/sql-tests/results/datetime.sql.out ---
    @@ -82,9 +82,10 @@ struct<a:int,b:int>
     1	2
     2	3
     
    +
     -- !query 9
     select weekday('2007-02-03'), weekday('2009-07-30'), weekday('2017-05-27'), weekday(null), weekday('1582-10-15 13:10:15')
    --- !query 3 schema
    +-- !query 9 schema
     struct<weekday(CAST(2007-02-03 AS DATE)):int,weekday(CAST(2009-07-30 AS DATE)):int,weekday(CAST(2017-05-27 AS DATE)):int,weekday(CAST(NULL AS DATE)):int,weekday(CAST(1582-10-15 13:10:15 AS DATE)):int>
    --- !query 3 output
    +-- !query 9 output
    --- End diff --
    
    @gatorsmile . This is very minor only in `branch-2.4`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org