You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org> on 2022/04/18 19:15:44 UTC

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18424


Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................

IMPALA-11127: [DOCS] document the UTF8_MODE query option

create a new topic for UTF_8 mode under SQL ref
discuss the new query option

Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
---
A docs/topics/impala_utf_8.xml
1 file changed, 103 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/18424/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/655/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 20 Apr 2022 15:20:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/655/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 20 Apr 2022 15:28:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................

IMPALA-11127: [DOCS] document the UTF8_MODE query option

add the new query option UTF8_MODE topic
update impala_string topic as requested in the first review
create a new topic for UTF_8 mode under SQL ref
discuss the new query option

Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Reviewed-on: http://gerrit.cloudera.org:8080/18424
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
---
M docs/impala.ditamap
M docs/topics/impala_string.xml
A docs/topics/impala_utf8_mode.xml
A docs/topics/impala_utf_8.xml
4 files changed, 163 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Quanlong Huang: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/656/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 21 Apr 2022 16:10:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/656/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 21 Apr 2022 16:17:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/654/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Apr 2022 19:15:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/654/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Apr 2022 19:23:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................


Patch Set 1:

(2 comments)

Can we also add a brief introduction for the new query option under this page?
https://impala.apache.org/docs/build/html/topics/impala_query_options.html

http://gerrit.cloudera.org:8080/#/c/18424/1/docs/topics/impala_string.xml
File docs/topics/impala_string.xml:

http://gerrit.cloudera.org:8080/#/c/18424/1/docs/topics/impala_string.xml@150
PS1, Line 150:       <li>
             :         String manipulation functions.
             :       </li>
Can we replace this with "CHAR/VARCHAR truncating/padding"? We now support UTF-8 string functions by the new query option.


http://gerrit.cloudera.org:8080/#/c/18424/1/docs/topics/impala_string.xml@173
PS1, Line 173:     </p>
Can we add a paragraph like this?

 If you just need Hive-compatible string function behaviors on UTF-8 encoded strings, turn on the query option UTF8_MODE. See more in <link of the UTF-8 page>.



-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 20 Apr 2022 13:46:05 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................


Patch Set 1: Code-Review+1

Thanks for addig this, LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Tue, 19 Apr 2022 07:46:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................


Patch Set 3: Code-Review+2

LGTM. Carry Tamas's +1. Thank Shajini!


-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 21 Apr 2022 22:24:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Tamas Mate, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18424

to look at the new patch set (#3).

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................

IMPALA-11127: [DOCS] document the UTF8_MODE query option

add the new query option UTF8_MODE topic
update impala_string topic as requested in the first review
create a new topic for UTF_8 mode under SQL ref
discuss the new query option

Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
---
M docs/impala.ditamap
M docs/topics/impala_string.xml
A docs/topics/impala_utf8_mode.xml
A docs/topics/impala_utf_8.xml
4 files changed, 163 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/18424/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Tamas Mate, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18424

to look at the new patch set (#2).

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................

IMPALA-11127: [DOCS] document the UTF8_MODE query option

update impala_string topic as requested in the first review
create a new topic for UTF_8 mode under SQL ref
discuss the new query option

Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
---
M docs/topics/impala_string.xml
A docs/topics/impala_utf_8.xml
2 files changed, 107 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/18424/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-11127: [DOCS] document the UTF8 MODE query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18424 )

Change subject: IMPALA-11127: [DOCS] document the UTF8_MODE query option
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18424/2/docs/topics/impala_string.xml
File docs/topics/impala_string.xml:

http://gerrit.cloudera.org:8080/#/c/18424/2/docs/topics/impala_string.xml@150
PS2, Line 150:  We now support UTF-8 string functions by the new query
             :         option.
Oops, don't add this..



-- 
To view, visit http://gerrit.cloudera.org:8080/18424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac5812a3f5e105a73ac87c1ae5fce69a776fb92
Gerrit-Change-Number: 18424
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 20 Apr 2022 15:27:59 +0000
Gerrit-HasComments: Yes